-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sysid] Rename quasistatic & dynamic to sweep and step respectively #7748
base: main
Are you sure you want to change the base?
[sysid] Rename quasistatic & dynamic to sweep and step respectively #7748
Conversation
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
Merging is definitely a post-season thing due to this change being breaking. |
Because this is breaking, you'll have to add deprecated shims that retain the old names for the robot-code-side classes/methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sysid side code needs to be updated to accept logs with tests named either way (so a newer sysid can process a log generated with older code).
In general I'm not sure of the value of making this change in-season. It feels pretty risky in terms of breakage for a very small name improvement.
As stated previously, merging will need to be a post-season thing due to being breaking. |
It might be better to just rename the enums, but keep the underlying logged names the same, so that compatibility with older logs doesn't break in sysid? Though some people pre-load their logs in AdvantageScope to ensure their data is good, and having the quasistatic/dynamic names there might be confusing |
- Oblarg
Really lazy Ctrl+H, it successfully compiles with all tests passing though.