Rewrite - Standalone frame #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bundle-wp-scripts
…bundle-wp-scripts
# Conflicts: # Gruntfile.js
|
|
||
| // Path to WordPress install. Either absoloute or relative to this plugin. | ||
| // Change this by passing --abspath="new/path" as a grunt option. | ||
| var abspath = grunt.option( "abspath" ) ? grunt.option( "abspath" ) : '/tmp/wordpress'; |
There was a problem hiding this comment.
Would it be possible to sniff the WP_DEVELOP_DIR environment variable too, so it works interchangeably with how PHPUnit tests work?
There was a problem hiding this comment.
I've added this too. Prioritiy is
- If passing abspath use that. (Allows running tests without setting up full test install)
- If environment var defined use that
- Else use
/tmp/wordpress
|
Lot of code changing here :) I'll check it out locally sometime in the next week or so to give it more of a click-through. For common reference, can you share some screenshots or GIFs of how it looks? |
…te-2-standalone-frame # Conflicts: # js/build/shortcode-ui.js # js/src/views/shortcode-ui.js
|
Yes this is a big one :) He'res a little video: https://www.youtube.com/watch?v=QOAlpes9rz8 Note - it includes the code from this which can go in first and is also fairly large: #581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some of the feedback we've had, I've pulled the 'Add post element' menu item out of the 'add media' modal, and into its own frame.
This is a bit of a big change, but would be interested to get some feedback on it.
From a UX perspective, I like it. Code wise, I like this too. Feels quite neat.
Heres a rundown of the changes.
views/shortcode-ui.jsandviews/media-frame.jsinto a single view. These were too tightly coupled and couldn't really be used independently of one another.MediaFrame.insertCallbackto do whatever you need. You would of course need to do a bunch of stuff yourself such as preview, edit, buttons etc. But theoretically its possible.Despite the complete rewrite of the media-frame code, it should still function very much as before.
NOTE - this DIFF is massive. But i've got a few other pull requests that can go in before this and will make it much more readable.