-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:chore: Add steps, functions to test lazyload images -- #56 #61
Conversation
Clicked on the approve button by mistake
src/support/steps/ll-css-bg-image.ts
Outdated
// eslint-disable-next-line @typescript-eslint/naming-convention | ||
lazyload_css_background_images: { | ||
initialImages: [ | ||
'https://new.rocketlabsqa.ovh/wp-content/rocket-test-data/images/test.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For images with e2e domain, can we read this from env variable so it can run on any e2e env? what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khadreal, I've checked all 3 scenarios. Scenario for the /ll_bg_css_double_colon template is failing because expected images no longer correspond. Left you the correct list of images in review. Thank you.
Description
Add test for lazyloading images.
Fixes #56
Documentation
The command to run
npm run test:llimages
User documentation
Explain how this code impacts users.
Technical documentation
Explain how this code works. Diagram & drawings are welcomed.
Type of change
New dependencies
List any new dependencies that are required for this change.
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Checklists
Feature validation
Documentation
Code style
Observability
Risks