Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #168: Tests for Check if content are lazyloaded while scrolling seems always failing for the templates lazyload_css_background_images, ll_bg_css_single_colon and ll_bg_css_double_colon #169

Merged

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes failing test caused by improper test cleanup/setup and strict assertions.

Fixes #168
Fixes failing scenario tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Issue can be reproduced by:

  • Activating WPML
  • Running npm run test:llimages

Technical description

Documentation

Deactivates WPML plugin before in the beforeAll hook and also removes strict assertion.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

@jeawhanlee jeawhanlee added the bug Something isn't working label Nov 19, 2024
@jeawhanlee jeawhanlee self-assigned this Nov 19, 2024
@jeawhanlee jeawhanlee requested a review from a team November 19, 2024 15:57
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Nov 20, 2024

On the 1st run , we had 1 test failing, then for the 2nd run all are passing (active theme is 2020)
report 1
https://drive.google.com/file/d/1ahLx9NHOcuQwa0GVK5pT_H1SaOXFEill/view?usp=sharing
report 2
Screenshot from 2024-11-20 17-52-15

smoke test on PR
Screenshot from 2024-11-20 18-01-02

@hanna-meda
Copy link
Contributor

All passed on my end, too, running for hanna.e2e on remote desktop, with theme 2020.
Screenshot 2024-11-20 at 18 37 06

@jeawhanlee jeawhanlee merged commit 80bde4e into develop Nov 21, 2024
2 checks passed
@jeawhanlee jeawhanlee deleted the fix/168/templates-for-ll-contents-while-scrolling-failing branch November 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants