remove external category properly #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalstruck
requested review from
andy-t-wang and
decentralgabe
as code owners
michalstruck
temporarily deployed
to
development
GitHub Actions
Inactive
michalstruck
temporarily deployed
to
development
GitHub Actions
Inactive
michalstruck
temporarily deployed
to
development
GitHub Actions
Inactive
andy-t-wang
reviewed
Feb 27, 2025
|
|
||
| if (!areAppCategoriesValid) { | ||
| return errorResponse({ | ||
| statusCode: 500, |
There was a problem hiding this comment.
Make sure the proper alert is set up. If this throws it will not alert us currently
There was a problem hiding this comment.
andy-t-wang
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Description
now compares category lowercase
also before returning checks whether all apps have a valid category
Checklist