Skip to content

Commit

Permalink
build: bump angular to 18 #TINFR-363 @yangzhenxing (#278)
Browse files Browse the repository at this point in the history
  • Loading branch information
wangyuan-ky authored and pubuzhixing8 committed Aug 21, 2024
1 parent c783f16 commit 896c5f9
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
build:
working_directory: ~/slate-angular
docker:
- image: cimg/node:18.16-browsers
- image: cimg/node:20.16.0-browsers
steps:
- browser-tools/install-chrome
- checkout
Expand Down
40 changes: 20 additions & 20 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
"url": "https://github.com/worktile/slate-angular"
},
"dependencies": {
"@angular/animations": "~17.2.4",
"@angular/common": "~17.2.4",
"@angular/compiler": "^17.2.4",
"@angular/core": "~17.2.4",
"@angular/forms": "~17.2.4",
"@angular/platform-browser": "~17.2.4",
"@angular/platform-browser-dynamic": "~17.2.4",
"@angular/router": "^17.2.4",
"@angular/animations": "~18.1.4",
"@angular/common": "~18.1.4",
"@angular/compiler": "^18.1.4",
"@angular/core": "~18.1.4",
"@angular/forms": "~18.1.4",
"@angular/platform-browser": "~18.1.4",
"@angular/platform-browser-dynamic": "~18.1.4",
"@angular/router": "^18.1.4",
"core-js": "3.35.0",
"direction": "^2.0.1",
"is-hotkey": "^0.2.0",
Expand All @@ -53,16 +53,16 @@
"zone.js": "~0.14.4"
},
"devDependencies": {
"@angular-devkit/build-angular": "^17.2.3",
"@angular-devkit/core": "^17.2.3",
"@angular-eslint/builder": "17.2.1",
"@angular-eslint/eslint-plugin": "17.2.1",
"@angular-eslint/eslint-plugin-template": "17.2.1",
"@angular-eslint/schematics": "17.2.1",
"@angular-eslint/template-parser": "17.2.1",
"@angular/cli": "^17.2.3",
"@angular/compiler-cli": "^17.2.4",
"@angular/language-service": "^17.2.4",
"@angular-devkit/build-angular": "^18.1.4",
"@angular-devkit/core": "^18.1.4",
"@angular-eslint/builder": "18.3.0",
"@angular-eslint/eslint-plugin": "18.3.0",
"@angular-eslint/eslint-plugin-template": "18.3.0",
"@angular-eslint/schematics": "18.3.0",
"@angular-eslint/template-parser": "18.3.0",
"@angular/cli": "^18.1.4",
"@angular/compiler-cli": "^18.1.4",
"@angular/language-service": "^18.1.4",
"@changesets/changelog-github": "^0.4.8",
"@changesets/cli": "^2.26.0",
"@commitlint/cli": "^18.4.4",
Expand Down Expand Up @@ -91,11 +91,11 @@
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"lint-staged": "^15.2.0",
"ng-packagr": "^17.2.1",
"ng-packagr": "^18.1.0",
"prettier": "^3.1.1",
"pretty-quick": "3.1.3",
"standard-version": "^9.5.0",
"ts-node": "~10.9.2",
"typescript": "~5.3.3"
"typescript": "~5.5.4"
}
}
4 changes: 2 additions & 2 deletions packages/src/view/container-item.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ComponentRef, Directive, EmbeddedViewRef, Input, TemplateRef, ViewContainerRef } from '@angular/core';
import { AngularEditor } from '../plugins/angular-editor';
import { SlateBlockCard } from '../components/block-card/block-card.component';
import { AngularEditor } from '../plugins/angular-editor';

import { ViewType } from '../types/view';
import { isComponentType, isDOMElement, isTemplateRef } from '../utils';
Expand Down Expand Up @@ -32,7 +32,7 @@ export abstract class ViewContainerItem<

getRootNodes(): HTMLElement[] {
if (this.embeddedViewRef) {
return this.embeddedViewRef.rootNodes.filter(rootNode => isDOMElement(rootNode));
return this.embeddedViewRef.rootNodes.filter(rootNode => isDOMElement(rootNode)) as HTMLElement[];
}
if (this.componentRef) {
return [this.componentRef.instance.nativeElement];
Expand Down

0 comments on commit 896c5f9

Please sign in to comment.