Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add option in orchestrator-core to pass UUID's in the state #570

Open
2 tasks
pboers1988 opened this issue Mar 18, 2024 · 2 comments · May be fixed by #878
Open
2 tasks

[Feature]: Add option in orchestrator-core to pass UUID's in the state #570

pboers1988 opened this issue Mar 18, 2024 · 2 comments · May be fixed by #878
Assignees
Labels
feature Request for new feature good first issue Good for newcomers

Comments

@pboers1988
Copy link
Member

pboers1988 commented Mar 18, 2024

Contact Details

No response

What should we build?

Currently we use str (or UUIDstr) to pass UUID's. This leads to endless conversions between the input form step (which mostly uses UUID's) and the following steps where we have to convert UUIDStr to UUID again.

Proposal: add possibility in Orchestrator core (see injectargs) to pass an UUID and list[UUID].

Tasks

  • Update orchestrator-core
  • Simplify workflows (can be done gradually) to take advantage of passing UUID's

Relevant pseudo code

No response

@pboers1988 pboers1988 added feature Request for new feature triage Issue that need to be triaged labels Mar 18, 2024
@wouter1975 wouter1975 changed the title [Feature]: Add option in orchestrator-core to pass UUID's in de state [Feature]: Add option in orchestrator-core to pass UUID's in the state Mar 25, 2024
@hanstrompert
Copy link
Member

Check if this works for UUID's. Add warning if UUIDstr is being used.

@hanstrompert hanstrompert removed the triage Issue that need to be triaged label Mar 3, 2025
@torkashvand
Copy link
Contributor

torkashvand commented Mar 5, 2025

We can add this deprecation warning when we starting the fast api server.

@hanstrompert hanstrompert added the good first issue Good for newcomers label Mar 5, 2025
@torkashvand torkashvand self-assigned this Mar 5, 2025
@torkashvand torkashvand linked a pull request Mar 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for new feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants