Language support is broken

[acidjunk]

When a language file exists in the orchestrator: the core doesn't see or use it.

Not sure if that's a bug in core or in the example app.

As a workaround: I'm now using a "translations" endpoint in the example app.

from pathlib import Path
from typing import Dict
import site

import structlog
from fastapi import Query
from fastapi.routing import APIRouter

from orchestrator.services.translations import _deep_merge_dict, _load_translations_file, Translations

from settings import settings

logger = structlog.get_logger(__name__)


router = APIRouter()

def generate_translations(language: str) -> Translations:
    orchestrator_core_path = Path(site.getsitepackages()[0]) / "orchestrator" / "workflows" / "translations"
    core_translations = _load_translations_file(language, orchestrator_core_path)
    user_translations = _load_translations_file(language, settings.TRANSLATIONS_DIR if settings.TRANSLATIONS_DIR else Path(__file__).parent.parent.parent.parent / "translations")
    return _deep_merge_dict(core_translations, user_translations)


@router.get("/{language}", response_model=dict)
def get_translations(language: str) -> Dict[str, str]:
    translations = generate_translations(language)

    return translations

As it's actually not possible to re-add an already existing endpoint I had to apply this dirty hack in the main:

from orchestrator import OrchestratorCore
from orchestrator.cli.main import app as core_cli
from orchestrator.settings import AppSettings

import products  # noqa: F401  Side-effects
import workflows  # noqa: F401  Side-effects
from api.api_v1.api import api_router

app = OrchestratorCore(base_settings=AppSettings())

if __name__ == "__main__":
    core_cli()
else:
    app.register_graphql()
    # remove the existing translation endpoint, so we can override it:
    app.router.routes = [route for route in app.router.routes if not route.__dict__["path"] == "/api/translations/{language}"]
    app.include_router(api_router, prefix="/api")

NOTE The v2 GUI: configures a lot of endpoint stuff in configuration.ts -> but the translations endpoint can't be configured there. @ricardovdheijden / @DutchBen