Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login shell flag so that environment variables are used. #252

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

twstokes
Copy link
Contributor

Environment variables from the interactive shell weren't being included when the "login shell" flag was supplied to Bash. Utilities like rbenv depend on environment variables to override the system version of Ruby.

@twstokes twstokes requested a review from geriux April 26, 2024 20:47
@twstokes twstokes added the bug Something isn't working label Apr 26, 2024
Copy link

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@twstokes twstokes merged commit 344105d into trunk Apr 29, 2024
2 checks passed
@twstokes twstokes deleted the fix/remove-npm-login-shell branch April 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants