Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checklist and include link to new basic test suite #235

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Update checklist and include link to new basic test suite #235

merged 1 commit into from
Jan 11, 2024

Conversation

fluiddot
Copy link
Contributor

After the new suite was added in wordpress-mobile/test-cases#161, we can remove the references to the writing flow and unsupported block editor, as they are now grouped in the basic test suite.

@fluiddot
Add link to basic test suite
9fa3bc4 
Note that this suite includes the writing flow and unsupported block editor cases.
@fluiddot fluiddot marked this pull request as ready for review January 11, 2024 14:46
@fluiddot fluiddot requested review from jhnstn and SiobhyB January 11, 2024 14:46
SiobhyB
SiobhyB approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fluiddot 🙌

@fluiddot fluiddot merged commit c8b239a into trunk Jan 11, 2024
2 checks passed
@fluiddot fluiddot deleted the update-checklist-with-basic-test-suite branch January 11, 2024 15:04
@fluiddot
Copy link
Contributor Author

@jhnstn I understand for new changes in gbm-cli we should follow the release steps described here and create a PR to bump the version, is this accurate?

@jhnstn
Copy link
Member

jhnstn commented Jan 15, 2024

@fluiddot that is correct.

@fluiddot fluiddot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @jhnstn @SiobhyB