Upgrade React Native 0.71.11 - Android changes
#5872
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,9 @@ const { | |
| } = e2eUtils; | ||
| import { NESTED_COLUMNS_3_LEVELS } from './test-editor-data'; | ||
|
|
||
| const ANDROID_COLUMN_APPENDER_BUTTON_XPATH = | ||
| '//android.widget.Button[@content-desc="Column Block. Row 1"]/android.view.ViewGroup[2]/android.view.ViewGroup/android.view.ViewGroup/android.view.ViewGroup/android.view.ViewGroup/android.view.ViewGroup/android.widget.Button'; | ||
|
|
||
| describe( 'Gutenberg Editor - Test Suite 1', () => { | ||
| describe( 'Columns block', () => { | ||
| it( 'displays placeholders when unselected', async () => { | ||
|
|
@@ -64,7 +67,7 @@ describe( 'Gutenberg Editor - Test Suite 1', () => { | |
| .elementByAccessibilityId( 'Column Block. Row 1' ) | ||
| .click(); | ||
| const appenderButton = await editorPage.waitForElementToBeDisplayedByXPath( | ||
| ANDROID_COLUMN_APPENDER_BUTTON_XPATH | ||
| ); | ||
| await appenderButton.click(); | ||
| } else { | ||
|
|
@@ -121,7 +124,7 @@ describe( 'Gutenberg Editor - Test Suite 1', () => { | |
| .elementByAccessibilityId( 'Column Block. Row 1' ) | ||
| .click(); | ||
| const appenderButton = await editorPage.waitForElementToBeDisplayedByXPath( | ||
| ANDROID_COLUMN_APPENDER_BUTTON_XPATH | ||
| ); | ||
| await appenderButton.click(); | ||
| } else { | ||
|
|
@@ -191,7 +194,7 @@ describe( 'Gutenberg Editor - Test Suite 1', () => { | |
| .elementByAccessibilityId( 'Column Block. Row 1' ) | ||
| .click(); | ||
| const appenderButton = await editorPage.waitForElementToBeDisplayedByXPath( | ||
| ANDROID_COLUMN_APPENDER_BUTTON_XPATH | ||
| ); | ||
| await appenderButton.click(); | ||
| } else { | ||
|
|
@@ -249,9 +252,7 @@ describe( 'Gutenberg Editor - Test Suite 1', () => { | |
| // Wait for the modal to open | ||
| await editorPage.driver.sleep( 3000 ); | ||
|
|
||
| const cellId = 'Column 1. Width is 50 Percent (%).'; | ||
|
There was a problem hiding this comment. Similar to this change, the accessibility hint is no longer appended to the accessibility content description on Android. |
||
| const cell = await editorPage.driver.elementByAccessibilityId( | ||
| cellId | ||
| ); | ||
|
|
||
Submodule gutenberg
updated
46 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked it further, but seems the native composition for
Buttonhas changed in the new version of RN or dependencies. I experienced something similar in Gutenberg with other elements (example).