Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SwiftLint in the project and on CI #147

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Feb 23, 2024

Description

This PR sets up SwiftLint as a SPM plugin and runs it on CI using the command run-swiftlint.

The main changes:

  • Adding the .swiftlint.yml file with the rules currently being checked and defining the SwiftLint version to use
  • Usage of the run-swiftlint command from a8c-ci-toolkit-buildkite-plugin in a new Buildkite step.
  • Adding SwiftLint as a SPM dependency and plugin
  • Fixing the currently found violations in the codebase

Testing Details

Make sure CI is 🟢


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia requested a review from mokagio February 23, 2024 18:55
@iangmaia iangmaia self-assigned this Feb 23, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the SwiftLint output in CI. Thanks @iangmaia

@iangmaia iangmaia merged commit da9c158 into trunk Feb 26, 2024
9 checks passed
@iangmaia iangmaia deleted the iangmaia/swiftlint-setup branch February 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants