Issue/423 prevent index overflows #424
Open
+20
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423
This is to resolve a crash which happened when
-[WPPHAssetDataSource photoLibraryDidChange:]
was called,with an invalid (seeming)changedIndexes
value.To test:
I wasn't ever able to actually reproduce the crash, but I believe it happened due to a combination of:
-[WPPHAssetDataSource adjustedIndexForIndex:forCount:]
-[NSMutableIndexSet addIndex:]
, which requires that the UInts it's passed be between 0 and NSIntegerMax -1.I've made a few tweaks to avoid that:
-[WPPHAssetDataSource adjustedIndexesForIndexSet:forCount:]
if it's greater than the count.assetCount
which may be out of date.I've tested it by adding to the indexes of any changes in
photoLibraryDidChange
, before passing them to the adjust functions, and checking that it doesn't crash. I tested in the Woo app.Testing steps:
CHANGELOG.md
if necessary.