[Feature] - 모니터링/로깅 시스템 통합 #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 30 files 30 suites 1m 1s ⏱️ Results for commit 4d9e534. ♻️ This comment has been updated with latest results. |
eunjungL
requested changes
Jan 3, 2025
Comment on lines
-127
to
-132
| server: | ||
| ssl: | ||
| key-store-type: PKCS12 | ||
| key-store-password: ENC(faQYah2QoIaNVRZD9J6/junPRWkc5gaiAs+mEbxDk+I=) | ||
| key-store: ENC(7VQCNdI7mXATwc4AiymZoyf3mz9SiskXpLnenpMSFBI=) | ||
|
|
There was a problem hiding this comment.
CD pipeline에서 키스토어를 생성해서 넣어주는 로직이 있는데요, 이 부분도 같이 제거되면 좋을 것 같네요!
겸사겸사 GitHub Secrets에서 관리하던 변수도 없애도 되겠네요 👍
There was a problem hiding this comment.
꼼꼼한 리뷰 감사합니다!
반영했으니 확인해 주세요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항
그라파나, 프로메테우스, 로키를 2개로 쪼개서 관리할 필요가 없다고 느껴져 하나로 통합하였습니다.
dev 프로파일에서 ssl 을 제거하였습니다.
ngnix에서 ssl termination 을 하도록 설정하고, 서브 도메인(
api-dev,grafana) 에 따라 프록시 패스를 하도록 설정하였습니다.