refactor: 도메인명 변경 (memory -> category, moment -> staccato) #594 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 33 files 33 suites 6s ⏱️ Results for commit dddb310. ♻️ This comment has been updated with latest results. |
🌻Test Coverage Report
|
linirini
requested changes
Jan 15, 2025
| return new CategoryNameResponses(categoryNameResponses); | ||
| } | ||
|
|
||
| public static StaccatoResponse toStaccatoResponse(MomentResponse momentResponse) { |
There was a problem hiding this comment.
하위 메서드에서만 사용하는 것 같네요! 접근 제어자를 private으로 변경해주세요!
There was a problem hiding this comment.
여기뿐만 아니라 StaccatoController에도 있었네요! 두 군데 모두 수정해주었습니다.
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
|
|
||
| @Schema(description = "추억에 대한 응답 형식입니다.") |
| public record CategoryNameResponse( | ||
| @Schema(example = "1") | ||
| Long categoryId, | ||
| @Schema(example = "런던 추억") |
There was a problem hiding this comment.
사소하지만 스키마 예시 중에 xx 추억처럼 되어있는 부분들도 같이 변경하면 어떨까요?
런던 추억보다는 런던 여행과 같은 표현이 저희에게는 더 자연스럽게 다가오지 않나 생각했어요:)
There was a problem hiding this comment.
런던 여행으로 수정해주었습니다!
Fixture의 '추억' 단어들은 원래 테스트 파일과 연관되어 있어, 다른 코드들이 머지된 후 수정하겠습니다.
linirini
approved these changes
Jan 17, 2025
Junyoung-WON
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary
구현 작업
memory->categorymoment->staccatocontroller,dto,swagger,test구현 방법
DtoMapper클래스를 만드는 방식으로 구현했습니다.클라이언트 api 변경 완료 시 바뀌는 부분
🙂 To Reviewer
파일을 복사해서 고치는 방식으로 했고 테스트도 전부 구현했기 때문에 큰 문제가 없을 것으로 예상됩니다.
눈으로 코드 전부를 따라가며 코드 리뷰하는 것은 어려움이 있을 것 같아,
pull 받아서 swagger를 확인해보는 방법이 리뷰 과정에 도움이 될 것 같습니다.
📋 To Do
나중에
도메인명 변경작업에서 이어서 할 부분service,repository,domain변경