Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 애플 로그인 회원 삭제 API 문서화 #955

Merged
merged 3 commits into from
Jan 19, 2025
Merged

docs: 애플 로그인 회원 삭제 API 문서화 #955

merged 3 commits into from
Jan 19, 2025

Conversation

mzeong
Copy link
Member

@mzeong mzeong commented Jan 14, 2025 •
edited
Loading

🚩 연관 이슈

close #951


📝 작업 내용

DELETE /v2/members

response code: 204

  • 403(권한 문제로 요청 거절) 추가됨

🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

@mzeong mzeong self-assigned this Jan 14, 2025
@github-actions GitHub Actions
Copy link

Test Results

 64 files  ±0   64 suites  ±0   13s ⏱️ ±0s
210 tests ±0  210 ✅ ±0  0 💤 ±0  0 ❌ ±0 
211 runs  ±0  211 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8400bf0. ± Comparison against base commit 848b444.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both. 
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [1] accessToken=com.ody.auth.token.AccessToken@1f1d3ddf
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [2] accessToken=com.ody.auth.token.AccessToken@4d6adc5a
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [1] date=2025-01-08, time=15:21:14.590490760, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [2] date=2025-01-08, time=16:21:14.590512531, expected=true
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [3] date=2025-01-08, time=14:21:14.590501150, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [4] date=2025-01-09, time=15:21:14.590490760, expected=true

com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [1] accessToken=com.ody.auth.token.AccessToken@21a15995
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [2] accessToken=com.ody.auth.token.AccessToken@7cc9df64
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [1] date=2025-01-14, time=19:00:30.795173500, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [2] date=2025-01-14, time=20:00:30.795193598, expected=true
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [3] date=2025-01-14, time=18:00:30.795183319, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [4] date=2025-01-15, time=19:00:30.795173500, expected=true

@github-actions GitHub Actions
Copy link

📝 Test Coverage Report

Overall Project 82.92% -0.05% 🍏
Files changed 0% ❌

File Coverage
MemberController.java 81.82% -18.18% ❌

@mzeong mzeong marked this pull request as ready for review January 14, 2025 13:26
eun-byeol
eun-byeol approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@eun-byeol eun-byeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐹! 간단한 질문만 남겼어요

backend/src/main/java/com/ody/member/controller/MemberController.java
@@ -24,4 +24,11 @@ public ResponseEntity<Void> delete(@AuthMember Member member) {
return ResponseEntity.status(HttpStatus.NO_CONTENT)
.build();
}

@Override
@DeleteMapping("/v2/members")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[질문]
v1이 아닌 v2인 이유가 궁금해요🤔

Copy link
Member Author

@mzeong mzeong Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 존재하는 api를 v1이라고 생각해서 v2라고 지었어요

coli-geonwoo
coli-geonwoo approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@coli-geonwoo coli-geonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 리뷰사안이 없어 approve & merge 합니다!

@coli-geonwoo coli-geonwoo merged commit 478c47f into develop Jan 19, 2025
3 checks passed
@mzeong mzeong deleted the feature/951 branch January 19, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coli-geonwoo coli-geonwoo coli-geonwoo approved these changes

@eun-byeol eun-byeol eun-byeol approved these changes

Assignees

@mzeong mzeong

Labels
BE DOCS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: 애플 로그인 회원 삭제 API 문서화
3 participants
@mzeong @eun-byeol @coli-geonwoo