[BE] 방 생성 때 방장도 참여 정할수 있게 변경 & DTO 리팩토링(#785) #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Test Results 70 files 70 suites 9s ⏱️ For more details on these failures, see this check. Results for commit 76d4182. ♻️ This comment has been updated with latest results. |
youngsu5582
force-pushed
the
feat/#785
branch
from
8f230b4 to
40dd10a
Compare
youngsu5582
force-pushed
the
feat/#785
branch
from
76d4182 to
f246d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
텐텐과 얘기하면서 DTO Depth 적절히 분배했습니다.
의 느낌으로 DTO 를 분리했습니다. ( 보기 편하라고 한 DTO 안에 다 넣어놨어용 )
( RoomResponse 에서 매니저 이름, RoomStatus&message 도 분리하고 싶었는데 당장은 뒀습니다. )
이렇게 분리하며 느낀점으론 Request 와 Response 는 명확하게 재사용 가능할 요소가 보였습니다.
이를 �ID 를 null 이 가능하게 해서 재사용이 가능하게 할 지 생각했는데 명확하지 않아서 우선은 분리했습니다.
추가로, Room 이 지금의 Request 를 기반으로 쪼갤 수 있지 않을까 생각했는데 이에 대해서도 의견주세용 🙂
p.s 만들면서도 이게 최선인가? 라는 생각이 들어서 부담없이 말해주삼용 🥲