[FE] 2주차 운영 피드백 반영(#704) #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chlwlstlf
approved these changes
Nov 4, 2024
Comment on lines
+46
to
+54
| // 방 종료 후 매칭 실패 상태의 화면 | ||
| if (roomInfo.roomStatus === "CLOSE" && roomInfo.message !== "") { | ||
| return ( | ||
| <S.TotalContainer> | ||
| <S.MessageWrapper>{MESSAGES.GUIDANCE.NO_PARTICIPANTS}</S.MessageWrapper> | ||
| </S.TotalContainer> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
종료 후 매칭 실패인 걸 알 수 있는 방법이 roomInfo.message !== "" 인데 주석이 없으면 모호할 것 같네요.! 백과 얘기해서 다른 방법도 생각해봐야 할 것 같습니당😂
pp449
approved these changes
Nov 4, 2024
| color: ${({ theme }) => theme.COLOR.grey3}; | ||
| text-align: center; | ||
| export const GithubIcon = styled.div` | ||
| flex-shrink: 0; |
There was a problem hiding this comment.
요거보고 flex-shrink에 대해 찾아봤는데 기본값이 0인데 이렇게 하면 차이가 있나요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용