-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 데모데이 피드백 반영(#698) #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lee sang Yeop <[email protected]> Co-authored-by: 강다빈 <[email protected]>
00kang
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 확인 완료~
pp449
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 좋아요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
코드리뷰 완료 문구 변경
코드리뷰 마치기
피드백 작성하기
피드백 수정하기
피드백 확인하기
나의리뷰이-내가 리뷰하는 사람 → 문구 폰트가 다르게 해서 강조되게 하기
프로세스보기에서 line-height 넣기
피드백 모아보기에서 쓴 피드백 부분 to 부분이 리뷰어, 리뷰이 오류 수정
방 정보 부분에 정보가 너무 많다(난잡하다)
마이페이지 - 프로필 클릭하면 깃허브로 넘어가는지 몰랐다 → 프로필 이름 옆에 깃허브 아이콘 추가
코드리뷰 완료 눌렀을 때 버튼에 로딩스피너 띄움 → 깃허브 API Future 사용해 두 개 같이 비동기로 작동
피드백 모아보기에서 방 상세페이지로 넘어가는 링크 넣음
현재 선택된 카테고리 sessionStorage로 관리
피드백 모아보기 파란 글씨로 변하는 거 수정