[FE] 피드백 모아보기 페이지 웹 접근성 추가 (#690) #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pp449
approved these changes
Oct 24, 2024
| <Button | ||
| onClick={onClose} | ||
| size="xSmall" | ||
| style={{ background: "transparent", color: "black" }} |
Comment on lines
+45
to
+50
| <> | ||
| <S.ScreenReader> | ||
| {selectedFeedbackType} 리스트에 {feedbackData.length}개의 미션이 있습니다. | ||
| </S.ScreenReader> | ||
|
|
||
| <S.FeedbackCardContainer> |
There was a problem hiding this comment.
Fragment 를 이용하기 보다 S.ScreenReader 를 FeedbackCardContainer 하위에 놔둬도 될거 같아요!
chlwlstlf
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용