Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 상세페이지 웹 접근성 추가(#645) #686

Merged
merged 13 commits into from
Oct 24, 2024
Merged

[FE] 상세페이지 웹 접근성 추가(#645) #686

merged 13 commits into from
Oct 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2024

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

이메일을 제거하였습니다.

상세 페이지에 접근성을 추가하였습니다.

  • 링크로 넘어가는 부분에 대해서는 클릭하면 ~~합니다 라는 문구를 추가하였습니다.
  • 나의 리뷰어, 리뷰이 목록은 table 시맨틱 태그로 변경하였습니다.

@github-actions github-actions bot added FE 프론트 개발 관련 작업 기능 기능 구현 작업 labels Oct 24, 2024
@chlwlstlf chlwlstlf self-assigned this Oct 24, 2024
Copy link
Member

@00kang 00kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텐텐 작업 수고했어용~~ 👍

@github-actions github-actions bot requested review from 00kang and pp449 October 24, 2024 08:30
Copy link
Contributor

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상세페이지에서 접근성 처리 잘 한거 같아요!

@@ -11,4 +11,4 @@ const getClientId = () => {
};

const clientId = getClientId();
export const githubAuthUrl = `https://github.com/login/oauth/authorize?client_id=${clientId}&scope=user:email`;
export const githubAuthUrl = `https://github.com/login/oauth/authorize?client_id=${clientId}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 처리해줬네요 👍👍

@pp449 pp449 merged commit 0a938d4 into develop Oct 24, 2024
4 checks passed
@pp449 pp449 deleted the feat/#645 branch October 24, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트 개발 관련 작업 기능 기능 구현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 상세페이지 웹 접근성 추가
3 participants