-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 상세페이지 웹 접근성 추가(#645) #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
텐텐 작업 수고했어용~~ 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상세페이지에서 접근성 처리 잘 한거 같아요!
@@ -11,4 +11,4 @@ const getClientId = () => { | |||
}; | |||
|
|||
const clientId = getClientId(); | |||
export const githubAuthUrl = `https://github.com/login/oauth/authorize?client_id=${clientId}&scope=user:email`; | |||
export const githubAuthUrl = `https://github.com/login/oauth/authorize?client_id=${clientId}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빠르게 처리해줬네요 👍👍
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
이메일을 제거하였습니다.
상세 페이지에 접근성을 추가하였습니다.
클릭하면 ~~합니다
라는 문구를 추가하였습니다.