Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 방 생성 검증 로직 주석 처리(#593) #594

Merged
merged 3 commits into from
Oct 12, 2024
Merged

[BE] 방 생성 검증 로직 주석 처리(#593) #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba95942
refactor: 방 생성 검증 로직 주석 처리
jcoding-play Oct 12, 2024
08bfa45
refactor: 운영 환경 설정 변경
jcoding-play Oct 12, 2024
b83ef23
refactor: 방 생성 검증 로직 테스트 disabled 처리
jcoding-play Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/main/java/corea/room/service/RoomService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class RoomService {

@Transactional
public RoomResponse create(long memberId, RoomCreateRequest request) {
validateDeadLine(request.recruitmentDeadline(), request.reviewDeadline());
// validateDeadLine(request.recruitmentDeadline(), request.reviewDeadline());

Member manager = memberRepository.findById(memberId)
.orElseThrow(() -> new CoreaException(ExceptionType.MEMBER_NOT_FOUND));
Expand Down
2 changes: 1 addition & 1 deletion backend/src/main/resources/config
Open in desktop
Submodule config updated from cfed68 to fcbd9b
3 changes: 3 additions & 0 deletions backend/src/test/java/corea/room/service/RoomServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import corea.room.dto.RoomResponses;
import corea.room.repository.RoomRepository;
import org.assertj.core.api.InstanceOfAssertFactories;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.RepeatedTest;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -68,6 +69,7 @@ void create() {
assertThat(roomRepository.findAll()).hasSize(1);
}

@Disabled
@Test
@DisplayName("방을 생성할 때 모집 마감 시간은 현재 시간보다 1시간 이후가 아니라면 예외가 발생한다.")
void invalidRecruitmentDeadline() {
Expand All @@ -81,6 +83,7 @@ void invalidRecruitmentDeadline() {
.isEqualTo(ExceptionType.INVALID_RECRUITMENT_DEADLINE);
}

@Disabled
@Test
@DisplayName("방을 생성할 때 리뷰 마감 시간은 모집 마감 시간보다 1일 이후가 아니라면 예외가 발생한다.")
void invalidReviewDeadline() {
Expand Down
Loading