Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 콜리네 서비스 제공 전 QA - 모달, 마이페이지(#563) #577

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 12, 2024

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

  • 사용자 아이디가 길 때 레이아웃 깨지는 문제
  • 모달 내에 체크박스가 없을 때 레이아웃 깨지는 문제
모바일 태블릿,데스크탑

@github-actions github-actions bot added FE 프론트 개발 관련 작업 디자인 디자인 관련 작업 labels Oct 12, 2024
@github-actions github-actions bot requested review from chlwlstlf and pp449 October 12, 2024 02:08
Copy link
Contributor

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업 확인했어요!

조경찬 (Jo Gyungchan) 보다 이름이 긴 경우엔 어떻게 되나요??

@00kang
Copy link
Member

00kang commented Oct 12, 2024

  • ellipsis 처리
  • 상세페이지에서 코드리뷰 완료 토스트 띄우기

이 작업도 추가적으로 완료했습니다!!

Copy link
Contributor

@chlwlstlf chlwlstlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 수고하셨어요!!!

Comment on lines +10 to +19
const { openToast } = useToast("success");

const queryClient = useQueryClient();

const postReviewCompleteMutation = useMutation({
mutationFn: ({ roomId, revieweeId }: { roomId: number; revieweeId: number }) =>
postReviewComplete(roomId, revieweeId),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: [QUERY_KEYS.REVIEWEES, roomId] });
openToast(MESSAGES.SUCCESS.POST_REVIEW_COMPLETE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니닷ㅠㅠ🙇‍♀️

@00kang 00kang merged commit 431d2ec into develop Oct 12, 2024
2 checks passed
@00kang 00kang deleted the fix/#563 branch October 12, 2024 06:08
jcoding-play pushed a commit that referenced this pull request Oct 12, 2024
* design: 모달에서 사용자 아이디가 길 때 wrap 처리

* design: 모달 버튼 제일 아래에 위치하도록 조정

* design: 모달 내 방장의 이름이 길 때 ... 처리

* feat: 코드리뷰 완료시 토스트 띄우기

---------

Co-authored-by: 00kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트 개발 관련 작업 디자인 디자인 관련 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 콜리네 서비스 제공 전 QA - 모달, 마이페이지
3 participants