Skip to content

Commit

Permalink
feat: pr 제출 안 했을 때 문구 추가
Browse files Browse the repository at this point in the history
  • Loading branch information
chlwlstlf committed Oct 12, 2024
1 parent 89333a0 commit 6138735
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
6 changes: 5 additions & 1 deletion frontend/src/@types/roomInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ export type Classification = "ALL" | "FRONTEND" | "BACKEND" | "ANDROID";

export type RoomStatus = "OPEN" | "CLOSE" | "PROGRESS" | "FAIL";

export type ParticipationStatus = "NOT_PARTICIPATED" | "PARTICIPATED" | "MANAGER";
export type ParticipationStatus =
| "NOT_PARTICIPATED"
| "PARTICIPATED"
| "MANAGER"
| "PULL_REQUEST_NOT_SUBMITTED";

export type Role = "BOTH" | "REVIEWER" | "REVIEWEE" | "NONE";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,11 @@ const MyReviewee = ({ roomInfo }: MyReviewerProps) => {
if (roomInfo.roomStatus === "CLOSE" && revieweeData.length === 0) {
return (
<S.GuidanceWrapper>
<p className="process-paused">{MESSAGES.GUIDANCE.FAIL_MATCHED}</p>
<p className="process-paused">
{roomInfo.participationStatus === "PULL_REQUEST_NOT_SUBMITTED"
? MESSAGES.GUIDANCE.PULL_REQUEST_NOT_SUBMITTED
: MESSAGES.GUIDANCE.FAIL_MATCHED}
</p>
</S.GuidanceWrapper>
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ const MyReviewer = ({ roomInfo }: MyReviewerProps) => {
if (roomInfo.roomStatus === "CLOSE" && reviewerData.length === 0) {
return (
<S.GuidanceWrapper>
<p className="process-paused">{MESSAGES.GUIDANCE.FAIL_MATCHED}</p>
<p className="process-paused">
{roomInfo.participationStatus === "PULL_REQUEST_NOT_SUBMITTED"
? MESSAGES.GUIDANCE.PULL_REQUEST_NOT_SUBMITTED
: MESSAGES.GUIDANCE.FAIL_MATCHED}
</p>
</S.GuidanceWrapper>
);
}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/constants/message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const GUIDANCE_MESSAGES = {
EMPTY_PARTICIPANTS: "참여자 목록은 매칭이 시작된 이후 공개됩니다.",
ZERO_PARTICIPANTS: "이 방의 참여자가 없습니다.",
ONLY_REVIEWER: "리뷰어로만 참여 중입니다!",
PULL_REQUEST_NOT_SUBMITTED: "PR을 제출하지 않아 매칭되지 않았습니다.",
};

const ERROR_MESSAGES = {
Expand Down

0 comments on commit 6138735

Please sign in to comment.