Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 타이머 Websocket에 STOMP 적용 #1068

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

JiHyeonL
Copy link
Contributor

@JiHyeonL JiHyeonL commented Feb 4, 2025

연관된 이슈

구현한 기능

  • 웹소켓 응답에 STOMP 적용

상세 설명

@JiHyeonL JiHyeonL self-assigned this Feb 4, 2025
@JiHyeonL JiHyeonL changed the title Be/feature/#1067 timer api to websocket [BE] 타이머 Websocket에 STOMP 적용 Feb 4, 2025
Comment on lines +76 to +79
// if (pairRoomWebSocketService.hasNoConnections(key) && schedulerRegistry.has(key)) {
// pauseTimer(key);
// return;
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

같이 회의해봅시다

package site.coduo.timer.service.dto;

public record TimerResponse(
Object data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 왜 Object 타입이십니까?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이머 상태를 보낼때는 String 타입이고, 타이머 시각을 보낼때는 long 타입이여서 TimerResponse로 한번에 데이터를 전송하려고 Object 타입을 사용해습니당

@JiHyeonL JiHyeonL merged commit 8d2a502 into BE/dev Feb 4, 2025
2 of 7 checks passed
@JiHyeonL JiHyeonL deleted the BE/feature/#1067-timer_api_to_websocket branch February 4, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants