UserCocktail service, controller를 구현한다. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toneyparky
requested changes
Feb 23, 2021
Comment on lines
16
to
21
| public class UserCocktailResponse { | ||
| private String name; | ||
| private String description; | ||
| private List<UserRecipeItemResponse> userRecipeItemResponses; |
There was a problem hiding this comment.
id 값도 넣어서 보내주는건 어떨까용?
전체조회에서 element를 클릭할 경우 상세조회를 할 경우에 필요할듯하네요~
Comment on lines
50
to
58
| fieldWithPath("userCocktailResponses").type(JsonFieldType.ARRAY).description("나만의 레시피 목록"), | ||
| fieldWithPath("userCocktailResponses.[].name").type(JsonFieldType.STRING).description("나만의 레시피 이름"), | ||
| fieldWithPath("userCocktailResponses.[].description").type(JsonFieldType.STRING) |
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @NoArgsConstructor |
There was a problem hiding this comment.
Suggested change
| @NoArgsConstructor | |
| @NoArgsConstructor(access = AccessLevel.PRIVATE) |
access를 달아줄까용?
| public List<UserRecipeItem> toUserRecipeItems(List<Ingredient> ingredients) { | ||
| List<UserRecipeItem> userRecipeItems = new ArrayList<>(); | ||
| for (int i = 0; i < ingredients.size(); i++) { | ||
| userRecipeItems.add(userRecipeItemRequests.get(i).toUserRecipeItem(ingredients.get(i))); |
There was a problem hiding this comment.
Suggested change
| userRecipeItems.add(userRecipeItemRequests.get(i).toUserRecipeItem(ingredients.get(i))); | |
| UserRecipeItem item = userRecipeItemRequests.get(i).toUserRecipeItem(ingredients.get(i)) | |
| userRecipeItems.add(item); |
요정도로 수정해서 가독성을 높혀도 좋을듯해요
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @NoArgsConstructor |
There was a problem hiding this comment.
Suggested change
| @NoArgsConstructor | |
| @NoArgsConstructor(access = AccessLevel.PRIVATE) |
😊
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @NoArgsConstructor |
There was a problem hiding this comment.
Suggested change
| @NoArgsConstructor | |
| @NoArgsConstructor(access = AccessLevel.PRIVATE) |
🙂
| } | ||
| } | ||
|
|
||
| public UserCocktailResponse findUserCocktail(Long id) { |
There was a problem hiding this comment.
@transactional(readOnly = true)
붙여주죠!
| .orElseThrow(() -> new EntityNotFoundException(ErrorCode.USERCOCKTAIL_NOT_FOUND)); | ||
| } | ||
|
|
||
| public UserCocktailResponses findUserCocktails() { |
|
resolve: #262 |
KimGyeong
changed the title
toneyparky
approved these changes
Feb 24, 2021
| void updateUserCocktail() throws Exception { | ||
| UserCocktailRequest userCocktailupdateRequest = UserCocktailRequest.builder() | ||
| .name("updateUserCocktail") | ||
| .description("해피해킹 없이는 살 수 없는 몸이 돼었어") |
| .andExpect(status().isNoContent()) | ||
| .andDo(print()) | ||
| .andDo(UserCocktailDocumentation.deleteUserCocktail()); | ||
|
|
- QuantityUnit 추가 - 나만의 레시피 권한 관리자 추가 - UserRecipeItemRequest 생성자 Validation 어노테이션 제거
- UserCocktailResponse id 필드 추가 - DTO 빈 생성자 접근 제어자 변경 - Transactional 어노테이션 추가
- 프론트의 amount => quantity, glass => quantity unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#262
현재 생성, 단일 조회, 전체 조회까지 마쳤습니다.
만들고보니 완성된 아이템의 색상을 만드는 로직이 어디서 들어가야 할 지 논의를 해봐야겠단 생각이 드네요.
오늘 업데이트와 삭제가 완료될 예정입니다.