Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

엔초-ServletUriComponentsBuilder.md #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

엔초-ServletUriComponentsBuilder.md #41

wants to merge 1 commit into from

Conversation

kwonyj1022
Copy link
Collaborator

No description provided.

JJ503
JJ503 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@JJ503 JJ503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백

  • Url에 대해 동적으로 처리가 가능한지 몰랐는데 쉽게 설명해 줘서 잘 이해할 수 있었습니다!
  • 예시는 프로젝트에서 사용한 예시보다는 재구성한 좀 더 쉬운 예시를 가져와도 좋을 것 같아요.

질문

  • queryParam 할 때 여러 개 하고 싶다면 queryParam에 대한 메서드를 여러 번 붙이면 되나요?

hgo641
hgo641 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@hgo641 hgo641 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url 맨날 String으로 때려박았는데, 동적으로 생성할 수 있게 해준다니 좋네요~~ 나중에 써보고싶습니다!
오늘 발표 덕분에 ServletUriComponentsBuilder란 무엇이고, 어떤 기능을 제공하는 지 알 수 있었습니다. 👍
어쩌다 동적으로 URL을 생성하는 기능이 필요하게 된 것인지 문제 상황과 필요성을 더 어필해줘도 좋을 것 같아요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgo641 hgo641 hgo641 approved these changes

@JJ503 JJ503 JJ503 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonyj1022 @JJ503 @hgo641