Various changes to get ARIA 1.1 compatibility. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes were made to match the spec at https://www.w3.org/TR/wai-aria-1.1/#combobox: * "combobox" role attribute added to the wrapper * "aria-haspopup" changed from "true" (which means "menu") to "listbox" to correctly match the role of the element containing the options * "aria-activedescendant" removed from the combobox element so it appears just on the element with the "textbox" role * "aria-multiline" set to "false" for the textbox element * "aria-owns" switched to "aria-controls" on the textbox element
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
…e base from upstream
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
…e base from upstream
YuriWPY
added a commit
to WhoPlusYou/select-woo
that referenced
this pull request
May 6, 2022
pull requests woocommerce#44 and woocommerce#45 are merged to our code base from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ARIA 1.1 per https://www.w3.org/TR/wai-aria-1.1/#combobox.
This pull request includes a
The following changes were made
to correctly match the role of the element containing the options
appears just on the element with the "textbox" role