Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for index in query #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/nodes/indexNode.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export type IndexNode = {
readonly kind: "IndexNode";
readonly index: string;
};

2 changes: 2 additions & 0 deletions src/nodes/queryNode.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { AttributesNode } from "./attributesNode";
import { ConsistentReadNode } from "./consistentReadNode";
import { ExpressionNode } from "./expressionNode";
import { IndexNode } from "./indexNode";
import { KeyConditionNode } from "./keyConditionNode";
import { LimitNode } from "./limitNode";
import { ScanIndexForwardNode } from "./scanIndexForwardNode";
Expand All @@ -14,5 +15,6 @@ export type QueryNode = {
readonly consistentRead?: ConsistentReadNode;
readonly scanIndexForward?: ScanIndexForwardNode;
readonly limit?: LimitNode;
readonly index?: IndexNode;
readonly attributes?: AttributesNode;
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`QueryQueryBuilder > fails a query with non-existent index 1`] = `[ValidationException: The table does not have the specified index: nonExistentIndex]`;

exports[`QueryQueryBuilder > handles a FilterExpression that takes attributes from cats array 1`] = `
[
{
Expand Down Expand Up @@ -363,6 +365,77 @@ exports[`QueryQueryBuilder > handles a query with a simple KeyCondition 1`] = `
]
`;

exports[`QueryQueryBuilder > handles a query with index 1`] = `
[
{
"dataTimestamp": 333,
"someBoolean": false,
"somethingElse": 10,
"userId": "123",
},
{
"dataTimestamp": 999,
"nested": {
"nestedBoolean": true,
"nestedString": "key",
},
"someBoolean": false,
"somethingElse": 0,
"userId": "123",
},
{
"dataTimestamp": 996,
"nested": {
"nestedBoolean": true,
"nestedNested": {
"nestedNestedBoolean": true,
},
"nestedString": "llol",
},
"someBoolean": false,
"somethingElse": -9,
"userId": "123",
},
{
"dataTimestamp": 222,
"someBoolean": true,
"somethingElse": 2,
"userId": "123",
},
{
"dataTimestamp": 111,
"nested": {
"nestedBoolean": false,
"nestedString": "koy",
},
"someBoolean": true,
"somethingElse": -5,
"userId": "123",
},
]
`;

exports[`QueryQueryBuilder > handles a query with limit 1`] = `
[
{
"dataTimestamp": 111,
"nested": {
"nestedBoolean": false,
"nestedString": "koy",
},
"someBoolean": true,
"somethingElse": -5,
"userId": "123",
},
{
"dataTimestamp": 222,
"someBoolean": true,
"somethingElse": 2,
"userId": "123",
},
]
`;

exports[`QueryQueryBuilder > handles a query with multiple expressions 1`] = `
[
{
Expand Down
30 changes: 30 additions & 0 deletions src/queryBuilders/queryQueryBuilder.integration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,34 @@ describe("QueryQueryBuilder", () => {

expect(data).toMatchSnapshot();
});

it("handles a query with limit", async () => {
const data = await tsynamoClient
.query("myTable")
.keyCondition("userId", "=", "123")
.limit(2)
.execute();

expect(data).toHaveLength(2);
expect(data).toMatchSnapshot();
})

it("handles a query with index", async () => {
const data = await tsynamoClient
.query("myTable")
.keyCondition("userId", "=", "123")
.index("myIndex")
.execute();

expect(data).toMatchSnapshot();
})

it("fails a query with non-existent index", async () => {
await expect(tsynamoClient
.query("myTable")
.keyCondition("userId", "=", "123")
.index("nonExistentIndex")
.execute()
).rejects.toThrowErrorMatchingSnapshot();
})
});
15 changes: 15 additions & 0 deletions src/queryBuilders/queryQueryBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export interface QueryQueryBuilderInterface<DDB, Table extends keyof DDB, O> {

limit(value: number): QueryQueryBuilderInterface<DDB, Table, O>;

index(index: string): QueryQueryBuilderInterface<DDB, Table, O>;

scanIndexForward(enabled: boolean): QueryQueryBuilderInterface<DDB, Table, O>;

consistentRead(enabled: boolean): QueryQueryBuilderInterface<DDB, Table, O>;
Expand Down Expand Up @@ -265,6 +267,19 @@ export class QueryQueryBuilder<
});
}

index(index: string): QueryQueryBuilderInterface<DDB, Table, O> {
return new QueryQueryBuilder<DDB, Table, O>({
...this.#props,
node: {
...this.#props.node,
index: {
kind: "IndexNode",
index,
},
},
});
}

scanIndexForward(
enabled: boolean
): QueryQueryBuilderInterface<DDB, Table, O> {
Expand Down
2 changes: 2 additions & 0 deletions src/queryCompiler/queryCompiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export class QueryCompiler {
filterExpression: filterExpressionNode,
keyConditions: keyConditionsNode,
limit: limitNode,
index: indexNode,
scanIndexForward: scanIndexForwardNode,
consistentRead: consistentReadNode,
attributes: attributesNode,
Expand Down Expand Up @@ -135,6 +136,7 @@ export class QueryCompiler {
? compiledFilterExpression
: undefined,
Limit: limitNode?.limit,
IndexName: indexNode?.index,
ExpressionAttributeValues: {
...Object.fromEntries(keyConditionAttributeValues),
...Object.fromEntries(filterExpressionAttributeValues),
Expand Down
11 changes: 11 additions & 0 deletions test/testFixture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ export const setupTestDDB = async (client: DynamoDBDocumentClient) => {
},
],
BillingMode: "PAY_PER_REQUEST",
GlobalSecondaryIndexes: [
{
IndexName: "myIndex",
KeySchema: [
{ AttributeName: "userId", KeyType: "HASH" },
],
Projection: {
ProjectionType: "ALL",
},
},
],
})
);

Expand Down