Meson improvements #641
Meson improvements #641
Conversation
Seems unused.
This way they don't have to set them manually.
Lets multiple projects use the same Tracy library.
|
Can you add a github action that would run the meson build path? It would make testing the changes easier. |
|
Yeah, let me try. |
YaLTeR
force-pushed
the
meson-improvements
branch
from
bba7a2d to
f5bab45
Compare
.github/workflows/gcc.yml
Outdated
| @@ -35,6 +35,8 @@ jobs: | |||
| run: make -j`nproc` -C import-chrome/build/unix debug release | |||
| - name: Library | |||
| run: make -j`nproc` -C library/unix debug release | |||
| - name: Library (meson) | |||
| run: meson setup build && meson compile -C build | |||
There was a problem hiding this comment.
This probably needs to be excluded on macos.
There was a problem hiding this comment.
Why so? Appears to have worked: https://github.com/YaLTeR/tracy/actions/runs/6572890389
There was a problem hiding this comment.
Never mind then. Maybe we should also do ninja install and then publish the artifacts?
There was a problem hiding this comment.
I thought about this a bit, especially considering that I do package this .so for my instrumented mutter repo. However, I don't think it makes much sense to do generally, because in practice you do want to set different defines based on the use-case (i.e. I set TRACY_ONLY_LOCALHOST for anything I send to others, yet I leave it off for my own machines), and a built library supports only a single set of defines. If it was configured at runtime instead, then it would make more sense to publish it IMO.
There was a problem hiding this comment.
I guess TRACY_ONLY_LOCALHOST is not a good example, TRACY_MANUAL_LIFETIME is a better one that needs explicit support from the profiled application.
There was a problem hiding this comment.
If it was configured at runtime instead, then it would make more sense to publish it IMO.
My intention was more to see what the install job does, if all the files are where they should be, etc. It may not be apparent just from looking at the build script.
There was a problem hiding this comment.
Hm, then could do an install with a prefix set to local dir. Meson prints all files it installs.
There was a problem hiding this comment.
YaLTeR
force-pushed
the
meson-improvements
branch
from
f5bab45 to
ed486bf
Compare
A number of meson improvements from my work to instrument Mutter and its dependencies. See individual commits.
The header install dir fix makes it work without errors, but it's still a bit ugly because it installs stuff into
/usr/include/client/and/usr/include/common/. Ideally everything should go under/usr/include/tracy/, but that breaks some include paths relying on../. I might try to figure it out later.