Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf-c/1.5.1 package update #41116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Feb 2, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Feb 2, 2025
Copy link
Contributor Author

octo-sts bot commented Feb 2, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output, I'll analyze and provide specific fixes:

• Detected Error:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
[...]
File to patch: 
Skip this patch? [y]

• Error Category: Build Configuration/Patch Application

• Failure Point: The patch application step is failing because it cannot find the files to patch

• Root Cause Analysis: The patch is being applied with incorrect path resolution. The patch expects to find files at specific paths, but the files aren't where the patch expects them to be relative to the working directory.

• Suggested Fix:

  1. Modify the patch step in the melange.yaml to include the strip option:
  - uses: patch
    with:
      patches: deprecated-FileDescriptorLegacy.patch
      strip: 1
  1. Alternative fix - verify the patch paths match the repository structure:
  - uses: patch
    with:
      patches: deprecated-FileDescriptorLegacy.patch
      directory: .

• Explanation:
The patch is failing because it can't find the files protoc-c/c_file.cc and protoc-c/c_helpers.h. Adding the strip option tells patch to ignore leading path components, which is usually needed when patches are created from git diffs. The strip level of 1 will remove one leading directory component from the paths in the patch file.

• Additional Notes:

  • The patch appears to be modifying protobuf-c compiler source files
  • The error suggests this is related to path resolution rather than the actual patch content
  • You may want to verify the patch file content matches the current version's file structure
  • Consider running patch --dry-run -p1 < deprecated-FileDescriptorLegacy.patch locally to test

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant