Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add service auto-enable in multiuser target #40197

Merged
merged 12 commits into from
Jan 23, 2025

Conversation

89luca89
Copy link
Contributor

enable by default some services linking to multiuser.target
add /etc/machine-id to systemd-init, it's needed to bootstrap some services
add kbd dependency for systemd-init

@89luca89 89luca89 requested review from smoser and xnox January 22, 2025 11:01
@89luca89 89luca89 requested a review from a team as a code owner January 22, 2025 11:01
Copy link
Member

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we chat about this

@89luca89 89luca89 marked this pull request as draft January 22, 2025 15:07
systemd.yaml Outdated Show resolved Hide resolved
xnox
xnox previously approved these changes Jan 22, 2025
@89luca89 89luca89 marked this pull request as ready for review January 22, 2025 18:40
@89luca89 89luca89 requested review from xnox and smoser January 22, 2025 18:40
@xnox xnox added the approved-to-run A repo member has approved this external contribution label Jan 23, 2025
@xnox
Copy link
Member

xnox commented Jan 23, 2025

@89luca89 other prs got merged; so this needs a rebase now.

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 23, 2025
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
@89luca89 89luca89 force-pushed the feat/enable_multiuser_target branch from 5475523 to b55583b Compare January 23, 2025 08:20
@89luca89
Copy link
Contributor Author

@89luca89 other prs got merged; so this needs a rebase now.

done 👍

Signed-off-by: Luca Di Maio <[email protected]>
xnox
xnox previously approved these changes Jan 23, 2025
justinvreeland
justinvreeland previously approved these changes Jan 23, 2025
xnox
xnox previously approved these changes Jan 23, 2025
@89luca89 89luca89 merged commit 026741f into wolfi-dev:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants