Replace Wikit Textarea with Codex Textarea component #771

guergana · 2023-11-20T17:50:50Z

This PR creates a wrapper around the Textarea component in Vue3.

Bug: T347190

itamargiv

Looks good so far, left my bits and bobs. But I would still encourage @hasanakg and @chukarave to leave their review.

resources/js/Pages/Home.vue

chukarave · 2023-11-27T10:59:26Z

This looks good to me and works well locally. It's a 👍 from me but i'll let @itamargiv approve since a review has already started.

hasanakg

Overall seems fine but why didn't we create a new wrapper component instead of crafting it inside Home.vue file?

guergana · 2023-11-28T12:45:05Z

Overall seems fine but why didn't we create a new wrapper component instead of crafting it inside Home.vue file?

Hi. I didn't think it was necessary. The new component doesn't add a lot of complexity compared to the other one, except for the fact that it has some nested elements.

hasanakg · 2023-11-28T12:52:25Z

Overall seems fine but why didn't we create a new wrapper component instead of crafting it inside Home.vue file?

Hi. I didn't think it was necessary. The new component doesn't add a lot of complexity compared to the other one, except for the fact that it has some nested elements.

You are right about complexity, but shouldn't it be a reusable component? I checked our plan of action on the ticket and our plan was also wrapping it as a component. T347190

guergana · 2023-11-28T13:47:15Z

Overall seems fine but why didn't we create a new wrapper component instead of crafting it inside Home.vue file?

Hi. I didn't think it was necessary. The new component doesn't add a lot of complexity compared to the other one, except for the fact that it has some nested elements.

You are right about complexity, but shouldn't it be a reusable component? I checked our plan of action on the ticket and our plan was also wrapping it as a component. T347190

Lol, you are right. I hadn't read the notes 😅 thanks for pointing it out

itamargiv

So far so good, I have left some comments even before testing locally. I will look into it later on to see why the tests are failing.

itamargiv · 2023-12-01T15:37:21Z

resources/js/Components/TextareaHome.vue

+  </cdx-field>
+</template>
+
+<script lang="ts">


Since this is a new component, I think we should use the composition API instead of the options API already. That is, we can use <script setup lang="ts"> here and not use defineComponent. See:

https://vuejs.org/guide/introduction.html#composition-api

https://vuejs.org/guide/typescript/composition-api.html#typescript-with-composition-api

resources/js/Components/TextareaHome.vue

itamargiv · 2023-12-01T15:54:51Z

resources/js/Pages/Home.vue

-                    :label="$i18n('item-form-id-input-label')"
-                    :placeholder="$i18n('item-form-id-input-placeholder')"
-                    :rows="8"
+                <textarea-home 


I am not so sure about calling the component textarea-home for two reasons.

This name implies and ties the component to be only used in the home page, and that it contains a textarea, both of which are just incidental.

It doesn't actually signify anything about what the component does.

Since the component is in charge of providing a search field for Item IDs, I think a better name for it would be something like item-id-search or something similar that really denotes its purpose.

Yes, wasn't sure what name to give it. Suggestions always come up faster in the review :D Thanks for the name. I still want to make sure it is clear that this is the textarea. I will call it item-id-search-textarea

itamargiv · 2023-12-01T16:02:21Z

resources/js/Pages/Home.vue

-                this.$inertia.get( '/results', { ids: this.serializeInput() } );
+                store.saveSearchedIds( this.textareaInputValue );
+                this.$inertia.get( '/results', 
+                    { ids: (this.$refs.textarea as InstanceType<typeof TextareaHome>).serializeInput() }


I'd prefer it if we didn't directly call component methods. While this can be done with composition API using defineExpose, the best practice here would be to emit an event with the already serialized input and use that event to save them to the component state. Then, this send method becomes much simpler, as it only needs to read the IDs from the state.

itamargiv · 2023-12-01T16:14:35Z

resources/js/Components/TextareaHome.vue

+      CdxTextArea,
+    },
+    setup() {
+        const store = useStore();


I wonder if we even need to rely on the state store here, if this is to be rally made reusable, we would get the IDs from a prop.

itamargiv · 2023-12-01T16:44:22Z

Alright, so I was looking into the testing errors and the problem is as always... Typescript. It actually doesn't build locally for me without raising errors. I think the issue is that we are using the this keyword on the $i18n calls within the methods, for example, in TextareaHome.vue:72 and the lines below it. Hopefully this should resolve once the component is converted to the composition API (and we will just have to use $i18n without the this keyword) but if not, we will talk about it again afterwards.

chukarave · 2023-12-14T13:42:20Z

resources/js/Components/ItemIdSearchTextarea.vue

+
+function splitInput(): Array<string> {
+    return textareaInputValue.value.split( '\n' );
+}


I think some spaces are needed in this line and after the next couple of functions. So close together is a bit messy on the eyes.

I've added some spaces.

chukarave · 2023-12-14T13:43:15Z

resources/js/Components/ItemIdSearchTextarea.vue

+
+const validationError: Ref<ValidationError> = ref(null);
+
+const banana = useI18n();


Are we sure this is the variable name we want to use for this? I'm on board if the answer is yes, just want to make sure we give this proper consideration

the plugin is called vue-banana-i18n, so banana is not such a strange name for the variable. In the use case we found in the original library they call it bananai18n, but it's almost the same. Later this is invoked as banana.i18n('message'). Naming it bananaI18n or even I18n wouldn't look very good.

If we want a more generic and descriptive name, maybe messages would be better here? That way it would be messages.i18n(\\...) upon invocation.

chukarave

Some very small nitpicks that should not delay merging

itamargiv

This looks good to me, thank you. I'll approve, but I still think you need to address Noa's comment about the naming.

itamargiv · 2023-12-14T15:26:41Z

resources/js/Components/ItemIdSearchTextarea.vue

+
+const validationError: Ref<ValidationError> = ref(null);
+
+const banana = useI18n();


If we want a more generic and descriptive name, maybe messages would be better here? That way it would be messages.i18n(\\...) upon invocation.

resources/js/app.ts

itamargiv

🤦 I forgot that there were changes I requested. Sorry. Other than that, I will track other issues in a tech debt log, since I think we can just move on with this.

chukarave · 2023-12-18T11:00:19Z

resources/js/Components/ItemIdSearchTextarea.vue

@@ -33,7 +33,7 @@ CdxTextArea.compatConfig = {

 const validationError: Ref<ValidationError> = ref(null);

-const banana = useI18n();
+const messages = useI18n();


chukarave

Looks good to me (and it was working well all along) 👍

The requested changes were made

chukarave

Approving again

chukarave · 2023-12-19T10:28:33Z

I'm gonna go ahead and merge this so it gets to staging

* Replace Wikit Textarea with Codex Textarea component Bug: T347190 * Fix v-model and add functionality * Remove this.form.itemsInput in favor of new v-model syntax * Fix errors * Remove trailing comma * Update browser tests * Update Home.vue * Update Home.spec.js * Put textarea in a wrapper component * Adjust tests to new TextareaHome component * Fix linting * Move MAX_NUM_IDS to TextArea component * Fix indentation * Rename component to ItemIdSearchTextarea * [WiP] rewrite component using Composition API * Commit unsuccesful testing export of i18n :( * Adjust i18n plugin to composition API with useI18n * Refactor global variable MAX_NUM_IDS to vue3 format * Fix typescript errors * Update HomeState to use the new ValidationError type * Add spaces between methods * Change name of internationalizaton plugin variable * Remove unneeded options in createI18n plugin

@itamargiv

* Localisation updates from https://translatewiki.net. (#722) * Update vue and peers (#758) * Install vue3 and dependencies * Mock correct version of inertia * Update error message fallback render function * Fix missing Vue import * Setup i18n * Setup pinia * Update defineComponent * Replace wikit-dialog with codex-dialog in Home.vue * Replace wikit-dialog with codex-dialog in Results.vue * Update bubble * Update lifecycle methods * Fix TS errors * Remove vuex from tests * Replace wikit dialog and select * Empty playground.vue * Add migration eslint rules * Update propsData to props * Update tests * Add lost package-lock.json * Setup i18n (#753) * Setup i18n * Remove unnecessary function --------- Co-authored-by: Itamar Givon <[email protected]> * Setup pinia * Resolve package-lock conflicts * Remove console.log * Restore Playground.vue * Fix linting issues * Update package-lock * Fix i18n (#760) * Enable parsing of wikitext style links in i18n messages * Update links in i18n messagesto wikitext style * Update browser tests (#759) * Fix browser tests * Disable assertVue assertions * Oops, missed two! --------- Co-authored-by: Itamar Givon <[email protected]> * Fix mix manifest --------- Co-authored-by: Hasan Akgün <[email protected]> * Replace wikit button with codex button (#764) * Replace wikit button with codex button Bug: T346797 * Update deps (#766) * update typescript-eslint * update vue-loader * update codex packages * Update php deps (#768) * update inertia * update guzzle-cache-middleware * update chore docs after Vue3 upgrade (#767) * Replace wikit Message by Codex Message component (#769) Bug: T347183 * Localisation updates from https://translatewiki.net. (#748) * Bump browserify-sign from 4.2.1 to 4.2.2 (#750) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump sass from 1.69.0 to 1.69.5 (#737) Bumps [sass](https://github.com/sass/dart-sass) from 1.69.0 to 1.69.5. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.69.0...1.69.5) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-node from 3.8.1 to 4.0.0 (#747) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.1 to 4.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.1...v4.0.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eslint-plugin-vue from 9.17.0 to 9.18.1 (#745) Bumps [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) from 9.17.0 to 9.18.1. - [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases) - [Commits](vuejs/eslint-plugin-vue@v9.17.0...v9.18.1) --- updated-dependencies: - dependency-name: eslint-plugin-vue dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3 to 4 (#746) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migrate to codex checkbox (#770) Bug: T347200 * Remove CSS not allowing CdxMessage to wrap in small screens (#774) The fix makes the success message properly adjust its width in viewports below 640px in Chrome v119, Safari v17 or Firefox v119 Bug: T347183 * Fix cdx-dialog styling and remove old wikit-dialog styles (#776) Bug: T347100 * Fix cdx-select width problems below 462px viewport width (#775) Bug: T347168 * Create Vue 3 version of the custom LanguageSelector component (#773) * Create Vue 3 version of the custom LanguageSelector component Bug: T345915 * Update indentation * Replace WikitLink component with Codex styles (#772) * replace links in AuthWidget * replace mismatch row links * add converted link styles * replace links in the tool footer * replace layout links * Rebase on development * include link mixin as default in app.scss * remove redundant css class and imports * remove forgotten redundant scss import * fix broken link styles * fix styling for the auth widget * adjust mismatch row headline styles * Replace results progress bar with codex component (#790) * replace results progress bar with codex component * add media query for smaller viewport * Replace Wikit Textarea with Codex Textarea component (#771) * Replace Wikit Textarea with Codex Textarea component Bug: T347190 * Fix v-model and add functionality * Remove this.form.itemsInput in favor of new v-model syntax * Fix errors * Remove trailing comma * Update browser tests * Update Home.vue * Update Home.spec.js * Put textarea in a wrapper component * Adjust tests to new TextareaHome component * Fix linting * Move MAX_NUM_IDS to TextArea component * Fix indentation * Rename component to ItemIdSearchTextarea * [WiP] rewrite component using Composition API * Commit unsuccesful testing export of i18n :( * Adjust i18n plugin to composition API with useI18n * Refactor global variable MAX_NUM_IDS to vue3 format * Fix typescript errors * Update HomeState to use the new ValidationError type * Add spaces between methods * Change name of internationalizaton plugin variable * Remove unneeded options in createI18n plugin * Localisation updates from https://translatewiki.net. (#777) * Localisation updates from https://translatewiki.net. (#797) * Use composition Api in Error.vue Page (#795) As discussed with @itamargiv the option of creating an automated test atm is too much overhead for the current task and will be addressed in the future as tech debt. Bug: T353719 * Remove Playground Page (#796) * Remove playground Page This page is no longer necessary as it was created at the beginning stage of the project to test the components. * Refactor Home page to Vue3 (#798) Bug: T353869 * Updates December 2023 (#799) * Bump @typescript-eslint/eslint-plugin from 6.11.0 to 6.13.1 (#779) * Bump @vue/test-utils from 2.4.2 to 2.4.3 (#780) * Bump @vue/runtime-dom from 3.3.8 to 3.3.9 (#781) * Bump @types/jest from 29.5.8 to 29.5.10 (#783) * Bump eslint from 8.53.0 to 8.54.0 (#784) * Bump typescript from 5.2.2 to 5.3.2 (#785) * Bump @types/lodash from 4.14.201 to 4.14.202 (#786) * Bump eslint-plugin-vue from 9.18.1 to 9.19.2 (#787) * Bump @typescript-eslint/parser from 6.11.0 to 6.13.1 (#788) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Localisation updates from https://translatewiki.net. (#801) * Rewrite Layout Page using Vue3 syntax (#802) Bug: T353886 * Fix indentation in Home Page (#803) * Improve links (#793) * don't show visited styles on auth links * don't show navigation outline on logo * Update resources/js/Components/AuthWidget.vue Co-authored-by: Guergana Tzatchkova <[email protected]> * Update resources/js/Components/AuthWidget.vue Co-authored-by: Guergana Tzatchkova <[email protected]> * fix indentation * remove redundant class --------- Co-authored-by: Guergana Tzatchkova <[email protected]> * Rewrite WikidataToolFooter in Vue3 script setup syntax (#824) * Rewrite WikidataToolFooter in Vue3 script setup syntax Bug: T354283 * Rewrite LoadingOverlay in Vue3 script setup syntax (#825) We expose the methods hide() and show() as well because they are used by the Results page Bug: T354345 * Rewrite AuthWidget in Vue3 script setup syntax (#827) Bug: T354373 * Rewrite Results Page in Vue 3 syntax (#805) Bug: T354059 * Rewrite MismatchesTable with Vue3 syntax (#828) * Rewrite MismatchesTable with Vue3 syntax Bug: T354375 * Rewrite MismatchRow in Vue3 script setup syntax (#826) Bug: T354346 * Add type null to User type to remove warnings (#829) When the user is not logged in the passed prop=null, this case should also be included in the User type. * Update composer laravel-socialite-mediawiki/ package (#834) * redirect composer to temporary GH package * Amend link to refer to repo, not branch * Fix design errors (#831) Bug: T347190 * Reassign css to proper div to remove white space below footer (#832) This wrapper div with the website class was collapsed into the <div id="app">. With the Vue3 rendering this is not happening anymore so the styles need to be reapplied directly to the div app. We need to disable no-multiple-template-root rule in project for this to work, since now there is more than one base element in the template but this error will be gone once the linting rules are set to Vue3 since this rule doesn't exist in Vue3. It will be migrated soon. Bug: T347190 * Replace all wikit variables in app.scss and _typography.scss (#792) * replace all wikit variables in app.scss and _typography.scss * include new body mixins * fix faulty variable name * replace dimension-layout tokens with temporary explicit values * replace dimension-spacing tokens with temporary explicit values * only include one body style mixin in * make tablet breakpoints into mobile breakpoints * add ui-text-M mixin, make font weight dynamic and use it on .button class * Improve links (#830) * align user line items * add redundant style property and fix indentation * Create a reusable custom variables file and use it for mismatch finder (#794) * add custom variables file and replace app.css vars * add custon variables css file and adjust path * replace variables in components and pages * fix incorrect/redundant values * Replace tokens in pages (#800) * import codex tokens in _typography.scss * replace tokens for `Home.vue` * replace tokens on * remove wikit tokens import from * add footer section titles style * replace all wikit variables in app.scss and _typography.scss * include new body mixins * fix faulty variable name * replace dimension-layout tokens with temporary explicit values * replace dimension-spacing tokens with temporary explicit values * only include one body style mixin in * make tablet breakpoints into mobile breakpoints * replace all wikit variables in app.scss and _typography.scss * include new body mixins * fix faulty variable name * replace dimension-layout tokens with temporary explicit values * replace dimension-spacing tokens with temporary explicit values * only include one body style mixin in * add custom variables file and replace app.css vars * add custon variables css file and adjust path * replace variables in components and pages * fix incorrect/redundant values * fix brackets removed unintentionally * Replace tokens in remaining components (#823) * import codex tokens in _typography.scss * replace tokens for `Home.vue` * replace tokens on * remove wikit tokens import from * add footer section titles style * replace all wikit variables in app.scss and _typography.scss * include new body mixins * fix faulty variable name * replace dimension-layout tokens with temporary explicit values * replace dimension-spacing tokens with temporary explicit values * only include one body style mixin in * make tablet breakpoints into mobile breakpoints * replace all wikit variables in app.scss and _typography.scss * include new body mixins * fix faulty variable name * replace dimension-layout tokens with temporary explicit values * replace dimension-spacing tokens with temporary explicit values * only include one body style mixin in * add custom variables file and replace app.css vars * add custon variables css file and adjust path * replace variables in components and pages * fix incorrect/redundant values * Replace tokens in remaining components * add and use new mixin * use mixin for all buttons * removing new mixin in order to include in PR #792 instead * don't apply button mixin to icon (also make it bold) * remove redundant wikit reference * get rid of trailing spaces * more white space removal * remove extra line * Find a way around icon - text misalignment issue in codex buttons (#837) * make text in all icon buttons its own span and style that * remove padding as it worsens the issue on chrome * Add explicit alignment to the icon as well Co-authored-by: Guergana Tzatchkova <[email protected]> --------- Co-authored-by: Guergana Tzatchkova <[email protected]> * Fix :visited:hover color for auth widget links (#838) * fix focus border outline for the store download button (#839) * Update linting rules to Vue3 (#836) This PR adds vue/vue3-strongly-recommended to check for vue linting violations in vue3 Bug: T351644 * Add stylelint to project (#841) The "selector-class-pattern" rule has been disabled because we are loosely following the BEM naming convention and this rule expects classes to be named using kebab case. Installing a plugin to reinforce the BEM convention would mean we also need to update all the class names that are not using it and that is too much overhead for the current task. * Adapt layout to codex's grid system (#849) * Adapt layout to codex's grid system * add a gap for the results description header * Bump eslint from 8.54.0 to 8.56.0 (#807) Bumps [eslint](https://github.com/eslint/eslint) from 8.54.0 to 8.56.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.54.0...v8.56.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/jest from 29.5.10 to 29.5.11 (#810) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.10 to 29.5.11. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump typescript from 5.3.2 to 5.3.3 (#814) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.3.2...v5.3.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/upload-artifact from 3 to 4 (#821) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-node from 4.0.0 to 4.0.1 (#822) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump sass-loader from 13.3.2 to 14.0.0 (#844) Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 13.3.2 to 14.0.0. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v13.3.2...v14.0.0) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @vue/runtime-dom from 3.3.9 to 3.4.15 (#845) Bumps [@vue/runtime-dom](https://github.com/vuejs/core/tree/HEAD/packages/runtime-dom) from 3.3.9 to 3.4.15. - [Release notes](https://github.com/vuejs/core/releases) - [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md) - [Commits](https://github.com/vuejs/core/commits/v3.4.15/packages/runtime-dom) --- updated-dependencies: - dependency-name: "@vue/runtime-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @vue/compiler-sfc from 3.3.8 to 3.4.15 (#851) Bumps [@vue/compiler-sfc](https://github.com/vuejs/core/tree/HEAD/packages/compiler-sfc) from 3.3.8 to 3.4.15. - [Release notes](https://github.com/vuejs/core/releases) - [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md) - [Commits](https://github.com/vuejs/core/commits/v3.4.15/packages/compiler-sfc) --- updated-dependencies: - dependency-name: "@vue/compiler-sfc" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump axios from 1.6.2 to 1.6.7 (#852) Bumps [axios](https://github.com/axios/axios) from 1.6.2 to 1.6.7. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.2...v1.6.7) --- updated-dependencies: - dependency-name: axios dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump date-fns from 2.30.0 to 3.3.1 (#853) Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.30.0 to 3.3.1. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Changelog](https://github.com/date-fns/date-fns/blob/main/CHANGELOG.md) - [Commits](date-fns/date-fns@v2.30.0...v3.3.1) --- updated-dependencies: - dependency-name: date-fns dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/eslint-plugin from 6.13.1 to 6.20.0 (#854) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.13.1 to 6.20.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.20.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @typescript-eslint/parser from 6.13.1 to 6.20.0 (#855) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.13.1 to 6.20.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.20.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Port the table component from Wikit back to the Mismatch Finder (#850) * Port the table component from Wikit to Mismatch Finder * fix ref export and add test * Rename component and replace discrete values with tokens where possible * two more tokens * use correct component name in test and css selector * update class selector name * make component tag kebab-case * Chore: Upgrade eslint-plugin-vue (#860) Bug: T356035 * Chore: Update sass Bug: T356035 * Chores: update ts-loader (#863) Bug: T356035 * add max-width for store unintentionally removed (#861) * Add overwritten button text span items (#864) * Remove Wikit MenuItem import (#865) Bug: T356172 * Remove compat build (#875) Bug: T351812 * Bump eslint-plugin-vue from 9.20.1 to 9.21.1 (#867) Bumps [eslint-plugin-vue](https://github.com/vuejs/eslint-plugin-vue) from 9.20.1 to 9.21.1. - [Release notes](https://github.com/vuejs/eslint-plugin-vue/releases) - [Commits](vuejs/eslint-plugin-vue@v9.20.1...v9.21.1) --- updated-dependencies: - dependency-name: eslint-plugin-vue dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump sass-loader from 14.0.0 to 14.1.0 (#868) Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 14.0.0 to 14.1.0. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v14.0.0...v14.1.0) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @vue/test-utils from 2.4.3 to 2.4.4 (#869) Bumps [@vue/test-utils](https://github.com/vuejs/test-utils) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/vuejs/test-utils/releases) - [Commits](vuejs/test-utils@v2.4.3...v2.4.4) --- updated-dependencies: - dependency-name: "@vue/test-utils" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add last layout and grid improvements (#874) * apply media queries on footer component * make sure button don't show ellipsis unnecessarily * add selector and move style from components to app.scss * add selector to random mismatches * Bump stylelint from 16.2.0 to 16.2.1 (#870) Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.2.0 to 16.2.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.2.0...16.2.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @wikimedia/language-data from 1.1.5 to 1.1.6 (#871) Bumps [@wikimedia/language-data](https://github.com/wikimedia/language-data) from 1.1.5 to 1.1.6. - [Release notes](https://github.com/wikimedia/language-data/releases) - [Changelog](https://github.com/wikimedia/language-data/blob/master/CHANGELOG.md) - [Commits](wikimedia/language-data@1.1.5...1.1.6) --- updated-dependencies: - dependency-name: "@wikimedia/language-data" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/jest from 29.5.11 to 29.5.12 (#872) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.11 to 29.5.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Don't show outline on logo (#877) * Add removed logo style * add empty line before media query * Remove Wikit Leftovers (#879) * remove wikit leftovers * tidy up indentation * remove link to broken tool (#878) * Ignore already reviewed mismatches on reupload (#880) Bug: T329631 Co-authored-by: Hasan Akgün <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: translatewiki.net <[email protected]> Co-authored-by: Itamar Givon <[email protected]> Co-authored-by: Hasan Akgün <[email protected]> Co-authored-by: Guergana Tzatchkova <[email protected]> Co-authored-by: Noa Rave <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Replace Wikit Textarea with Codex Textarea component

4dd4db7

Bug: T347190

guergana marked this pull request as draft November 20, 2023 17:50

guergana added 2 commits November 21, 2023 17:01

Fix v-model and add functionality

e4e5ff7

Remove this.form.itemsInput in favor of new v-model syntax

0410cb1

guergana changed the title ~~[WiP] Replace Wikit Textarea with Codex Textarea component~~ Replace Wikit Textarea with Codex Textarea component Nov 21, 2023

Fix errors

b62c91c

guergana force-pushed the replace-textarea-codex branch from 853f861 to b62c91c Compare November 21, 2023 17:04

guergana added 2 commits November 21, 2023 18:05

Remove trailing comma

9fd7600

Update browser tests

22c83c6

guergana marked this pull request as ready for review November 21, 2023 17:21

guergana requested review from hasanakg and chukarave November 21, 2023 17:21

itamargiv reviewed Nov 21, 2023

View reviewed changes

resources/js/Pages/Home.vue Outdated Show resolved Hide resolved

resources/js/Pages/Home.vue Show resolved Hide resolved

resources/js/Pages/Home.vue Outdated Show resolved Hide resolved

guergana added 2 commits November 22, 2023 11:37

Update Home.vue

9d70229

Update Home.spec.js

9aa3703

guergana requested a review from itamargiv November 22, 2023 10:46

hasanakg reviewed Nov 27, 2023

View reviewed changes

guergana requested a review from hasanakg November 28, 2023 12:47

guergana added 3 commits November 30, 2023 17:59

Put textarea in a wrapper component

5021f51

Adjust tests to new TextareaHome component

242bf73

Fix linting

6028a8f

guergana force-pushed the replace-textarea-codex branch from c96afa0 to 6028a8f Compare November 30, 2023 17:19

itamargiv requested changes Dec 1, 2023

View reviewed changes

Move MAX_NUM_IDS to TextArea component

64e9048

guergana added 3 commits December 4, 2023 12:56

Fix indentation

54cd3f7

Rename component to ItemIdSearchTextarea

97f4f8e

[WiP] rewrite component using Composition API

fcf168c

guergana force-pushed the replace-textarea-codex branch from 2233942 to fcf168c Compare December 4, 2023 14:55

guergana added 4 commits December 11, 2023 19:14

Commit unsuccesful testing export of i18n :(

5dffb0c

Adjust i18n plugin to composition API with useI18n

94b4505

Refactor global variable MAX_NUM_IDS to vue3 format

fdb98aa

Fix typescript errors

ea871ca

guergana requested a review from itamargiv December 13, 2023 18:59

Update HomeState to use the new ValidationError type

d50dd53

chukarave reviewed Dec 14, 2023

View reviewed changes

Add spaces between methods

011a249

itamargiv approved these changes Dec 15, 2023

View reviewed changes

itamargiv previously requested changes Dec 15, 2023

View reviewed changes

Change name of internationalizaton plugin variable

35af9ff

guergana requested review from itamargiv and chukarave December 18, 2023 09:45

chukarave reviewed Dec 18, 2023

View reviewed changes

chukarave previously approved these changes Dec 18, 2023

View reviewed changes

Remove unneeded options in createI18n plugin

e6ea197

guergana dismissed chukarave’s stale review via e6ea197 December 18, 2023 11:10

chukarave approved these changes Dec 18, 2023

View reviewed changes

chukarave merged commit f88bb49 into development Dec 19, 2023
5 checks passed

chukarave deleted the replace-textarea-codex branch December 19, 2023 10:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Wikit Textarea with Codex Textarea component #771

Replace Wikit Textarea with Codex Textarea component #771

guergana commented Nov 20, 2023 •

edited

Loading

itamargiv left a comment

chukarave commented Nov 27, 2023

hasanakg left a comment

guergana commented Nov 28, 2023

hasanakg commented Nov 28, 2023

guergana commented Nov 28, 2023

itamargiv left a comment •

edited

Loading

itamargiv Dec 1, 2023

itamargiv Dec 1, 2023

guergana Dec 4, 2023 •

edited

Loading

itamargiv Dec 1, 2023

itamargiv Dec 1, 2023 •

edited

Loading

itamargiv commented Dec 1, 2023

chukarave Dec 14, 2023

guergana Dec 14, 2023

chukarave Dec 14, 2023 •

edited

Loading

guergana Dec 14, 2023 •

edited

Loading

itamargiv Dec 14, 2023

chukarave left a comment

itamargiv left a comment

itamargiv Dec 14, 2023

itamargiv left a comment

chukarave Dec 18, 2023

chukarave left a comment

chukarave left a comment

chukarave commented Dec 19, 2023


		const validationError: Ref<ValidationError> = ref(null);

		const banana = useI18n();

Replace Wikit Textarea with Codex Textarea component #771

Replace Wikit Textarea with Codex Textarea component #771

Conversation

guergana commented Nov 20, 2023 • edited Loading

itamargiv left a comment

Choose a reason for hiding this comment

chukarave commented Nov 27, 2023

hasanakg left a comment

Choose a reason for hiding this comment

guergana commented Nov 28, 2023

hasanakg commented Nov 28, 2023

guergana commented Nov 28, 2023

itamargiv left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guergana Dec 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itamargiv Dec 1, 2023 • edited Loading

Choose a reason for hiding this comment

itamargiv commented Dec 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chukarave Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

guergana Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chukarave left a comment

Choose a reason for hiding this comment

itamargiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itamargiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chukarave left a comment

Choose a reason for hiding this comment

chukarave left a comment

Choose a reason for hiding this comment

chukarave commented Dec 19, 2023

guergana commented Nov 20, 2023 •

edited

Loading

itamargiv left a comment •

edited

Loading

guergana Dec 4, 2023 •

edited

Loading

itamargiv Dec 1, 2023 •

edited

Loading

chukarave Dec 14, 2023 •

edited

Loading

guergana Dec 14, 2023 •

edited

Loading