Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typescript from 5.6.3 to 5.7.2 #556

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2025

Bumps typescript from 5.6.3 to 5.7.2.

Release notes

Sourced from typescript's releases.

TypeScript 5.7

For release notes, check out the release announcement.

Downloads are available on:

TypeScript 5.7 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.7 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits
  • d701d90 Bump version to 5.7.2 and LKG
  • 0503a63 🤖 Pick PR #60450 (Move to file: fix detection of refe...) into release-5.7 (#...
  • 3140dbb 🤖 Pick PR #60488 (Stub out copilotRelated command) into release-5.7 (#60495)
  • c1216de Update LKG
  • 3ee2b95 🤖 Pick PR #60415 (Fix false positive rewriteRelativeI...) into release-5.7 (#...
  • 44bd3f2 Bump version to 5.7.1-rc and LKG
  • 5925c81 Update LKG
  • 84d58cf Merge remote-tracking branch 'origin/main' into release-5.7
  • 0ec4d30 Fixing exception on unsaved file (#60362)
  • 11b2930 Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Ar...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 7, 2025
@dependabot dependabot bot requested a review from a team January 7, 2025 13:40
@moiikana
Copy link
Contributor

moiikana commented Jan 7, 2025

@dependabot rebase

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.6.3 to 5.7.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.6.3...v5.7.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-5.7.2 branch from 6481af4 to 23aa827 Compare January 7, 2025 13:59
@Sperling-0 Sperling-0 force-pushed the dependabot/npm_and_yarn/typescript-5.7.2 branch 2 times, most recently from 5f9d09a to a178063 Compare January 8, 2025 10:22
@@ -58,7 +58,7 @@ export class SubtleDataEncryptor implements DataEncryptor {
}

stringToArrayBuffer( data: string ): ArrayBuffer {
return new TextEncoder().encode( data );
return new TextEncoder().encode( data ).buffer as ArrayBuffer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look at the Typescript release notes and they mention the error message: https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/#typedarrays-are-now-generic-over-arraybufferlike

Since casting in TypeScript is error-prone and can lead to subtle errors, I recommend changing the return type for stringToArrayBuffer. Just let it return Uint8Array. The receiving function, SubtleCrypto.encrypt can take several types, one of them TypedArray. Uint8Array extends the TypedArray base class, so we're good here.

@Sperling-0 Sperling-0 force-pushed the dependabot/npm_and_yarn/typescript-5.7.2 branch from a178063 to 74a9517 Compare January 8, 2025 15:19
@moiikana moiikana merged commit b6851a3 into main Jan 8, 2025
3 checks passed
@moiikana moiikana deleted the dependabot/npm_and_yarn/typescript-5.7.2 branch January 8, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants