Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethernet-lan.md #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SturdyPete
Copy link

I recently had some trouble getting a custom PCBA with LAN8720A working with WLED. Having got it working, I wanted to update the documentation to make it easier for those who come after me to not make the same mistakes.

  • add note regarding GPIO0 clock output and LAN87xx requiring an inverter, prefer GPIO17 for clock output in this case
  • add documentation for adding custom PCB with ethernet to the WLED build
  • minor grammar corrections to existing text

add note regarding GPIO0 clock output and LAN87xx
add documentation for adding custom PCB with ethernet to the WLED build
Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a few things to be modified.

- Most of Ethernet based controllers/ adapters are based on LAN87xx IC. It requires proper reset line. Unfortunately, some simple/cheap adapters do not implement this line correctly that might lead to instabilities especially during boot up.
- ESP32 can be configured to provide the 50MHz clock for the PHY on GPIO0, GPIO16 or GPIO17. For operation with LAN87xx IC, use GPIO17. If you want to use GPIO0 with LAN87xx, you will need to add an inverter between GPIO0 and the LAN87xx CLKIN pin.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information is clearly stated in Espressif documentation and a reference to it should be added here if you want this text to be included.
https://docs.espressif.com/projects/esp-idf/en/v5.1/esp32/hw-reference/esp32/get-started-ethernet-kit.html#rmii-clock-sourced-internally-from-esp32-s-apll

@@ -39,5 +40,22 @@ ESP32Deux | | 17, 18, 23
[WESP32](https://wesp32.com/) | | 0, 16, 17
[WT32-ETH01](https://www.seeedstudio.com/Ethernet-module-based-on-ESP32-series-WT32-ETH01-p-4736.html) | | 0, 16, 18, 23

## Defining GPIO for a custom PCBA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading or incorrectly worded heading.
IMO it should read: Creating custom/new Ethernet board option in WLED


The following PHY are supported by WLED according to the header ETH.h:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETH.h is not part of WLED and WLED does not support anything but LAN8720A and IP101.

settings_wifi.htm | 221 | add your board name and enum index


note that you will need to recompile the html, see [Changing web UI for instruction](https://github.com/Aircoookie/WLED/wiki/Add-own-functionality/a30b2f3004c9aafc0639138afbff73b4efe4a766)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary in 0.15 as it is done automatically if the environment is set up correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants