acl: fixed acl rule bug. add some allowed actions

wkpark · Nov 2, 2022 · 9d00a8b · 9d00a8b
1 parent fcba4fe
commit 9d00a8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/config/acl.default.php.sample b/config/acl.default.php.sample
@@ -6,7 +6,7 @@
 #
 @Guest	Anonymous
 *	@ALL		deny	*
-*	@ALL		allow	edit,markup,ticket,savepage,titleindex,bookmark,pagelist,pagelist/ajax,identicon,oekaki
+*	@ALL		allow	notfound,edit,markup,recall,likepages,login,ticket,savepage,titleindex,bookmark,pagelist,pagelist/ajax,identicon,autogoto,retroidenticon,pagecount,scrap,recentchanges
 *	@ALL		allow	randompage,identicon,retroidenticon,pagesort
 *	@ALL		allow	autogoto,goto,notfound,likepages,titlesearch,backlinks
 *	@User		allow	*

diff --git a/plugin/security/acl.php b/plugin/security/acl.php
@@ -65,16 +65,15 @@ function __construct($DB="") {
                 list($pages, $rules, $group) = $this->parse_acl($acl_lines);
                 // save group definitions
                 $cache->update('acl_group', $group);
-
                 // save individual acl of all pages
                 foreach ($pages as $pagename=>$acl) {
                     $this->cache->update($pagename, $acl, 0, $params);
                 }
                 // save default ACL
                 $cache->update('acl_default', $rules['*']);
-                unset($rules['*']);
                 // make all in one regex for all patthern
                 $tmp = array_keys($rules);
+                unset($tmp[0]);
                 $rule = '('.implode(')|(', $tmp).')';
 
                 $vals = array_values($rules);