-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom content patterns. #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content itself looks good to me, but a redirect is needed.
P.S: I am no longer a maintainer of this repo, just passing by
@@ -78,7 +78,8 @@ extensibility: | |||
- extending-wiremock | |||
- extensibility/filtering-requests | |||
- extensibility/transforming-responses | |||
- extensibility/custom-matching | |||
- extensibility/custom-request-matching | |||
- extensibility/custom-content-matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If implemented as is, it breaks the original page access. At least a redirect is needed in the markdown file
@@ -1,6 +1,6 @@ | |||
--- | |||
layout: docs | |||
title: Custom Matching | |||
title: Custom Request Matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine. @oleg-nenashev is correct about the redirect though. Changing the name of the file will change the url structure so all the indexed pages in the search engines will return a 404. If you take a look at the other pages on the site, some of them have a redirect_from
element in the front matter. This is what we need here
Thank you for the contribution. I will add the redirect as a separate update before publishing the site |
This PR should not have been merged. The original PR, wiremock/wiremock#2592 (as noted in the references), was never merged and so this content should not be published. |
Ah, sorry. My bad |
Will see if I can revert it |
Couldn't automatically revert the PR due to the redirect I added so I have backed out the changes in a separate PR - #333 Sorry for the hassle. Would you be able to raise the PR again ? |
Demonstrate how users can create
ContentPatternExtension
s for extending WireMock's matching abilities.References
Submitter checklist
it is submitted against the 2.x branch
Details: Contributor Guide