Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom content patterns. #285

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kyle-winkelman
Copy link
Contributor

Demonstrate how users can create ContentPatternExtensions for extending WireMock's matching abilities.

References

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • If the change against WireMock 2 functionality (incompatible with WireMock 3),
    it is submitted against the 2.x branch
  • The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content itself looks good to me, but a redirect is needed.
P.S: I am no longer a maintainer of this repo, just passing by

@@ -78,7 +78,8 @@ extensibility:
- extending-wiremock
- extensibility/filtering-requests
- extensibility/transforming-responses
- extensibility/custom-matching
- extensibility/custom-request-matching
- extensibility/custom-content-matching
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If implemented as is, it breaks the original page access. At least a redirect is needed in the markdown file

@@ -1,6 +1,6 @@
---
layout: docs
title: Custom Matching
title: Custom Request Matching
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine. @oleg-nenashev is correct about the redirect though. Changing the name of the file will change the url structure so all the indexed pages in the search engines will return a 404. If you take a look at the other pages on the site, some of them have a redirect_from element in the front matter. This is what we need here

@leeturner leeturner merged commit b370bfb into wiremock:main Jan 16, 2025
1 check passed
@leeturner
Copy link
Contributor

Thank you for the contribution. I will add the redirect as a separate update before publishing the site

@kyle-winkelman
Copy link
Contributor Author

This PR should not have been merged. The original PR, wiremock/wiremock#2592 (as noted in the references), was never merged and so this content should not be published.

@leeturner
Copy link
Contributor

Ah, sorry. My bad

@leeturner
Copy link
Contributor

Will see if I can revert it

leeturner added a commit that referenced this pull request Jan 16, 2025
This commit reverts PR #285. #285 was merged in error but couldn't be
reverted automatically due to a commit that was performed on one of the
new files after merge.  This PR reverts back to the state prior to the
merge of PR #285
@leeturner leeturner mentioned this pull request Jan 16, 2025
4 tasks
@leeturner
Copy link
Contributor

Couldn't automatically revert the PR due to the redirect I added so I have backed out the changes in a separate PR - #333

Sorry for the hassle. Would you be able to raise the PR again ?

leeturner added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants