Use Serial from EDID as IDs #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want nodes to be able to report their state back. Use the same types previously introduced in https://github.com/flokli/display-agent
We always pass a Some() in there. Also name the two channel ends tx/rx at creation.
Populate the Info struct with values from the EDID, and pass the serial down to the mqtt listener.
nikstur
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the serial from the EDID as ID if available, only falling back to machine-id if it cannot be read/parsed.
An ID explicitly configured in the config file still has priority.
This is the ID shown as "Display Product Serial Number" by
edid-decode.