UI - Fixed font size of buttons #1291
Open
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property (which has been removed) overrides the font size for all buttons. This causes the font to display incorrectly for buttons of different sizes: https://wintercms.com/docs/v1.2/ui/controls/button#sizes
Screenshot before:
Screenshot after:
Initially, the
font-size
property is already defined here:winter/modules/system/assets/ui/less/button.base.less
Line 15 in 206e738
If we want the default font size to be
13px
(as overridden in the property I removed), then perhaps we should change the@font-size-base
parameter to@font-size-base - 1
Correct to:
I don't remember if it is possible to pass a calculated expression in parameters for LESS
Mixin:
winter/modules/system/assets/ui/less/button.mixins.less
Line 97 in 206e738
Class sizes are listed here
winter/modules/system/assets/ui/less/button.base.less
Lines 147 to 160 in 206e738
I don't have the technical ability to recompile styles from LESS.