Apply suggestions from code review

Co-authored-by: Luke Towers <[email protected]>
wintercms · Jan 5, 2025 · d8d9850 · d8d9850
1 parent 6900cae
commit d8d9850
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/modules/system/classes/UpdateManager.php b/modules/system/classes/UpdateManager.php
@@ -46,7 +46,7 @@ protected function init()
 
     public function isSystemSetup(): bool
     {
-        return !Schema::hasTable($this->getMigrationTableName());
+        return Schema::hasTable($this->getMigrationTableName());
     }
 
     public function getMigrationTableName(): string

diff --git a/modules/system/classes/extensions/ModuleManager.php b/modules/system/classes/extensions/ModuleManager.php
@@ -52,7 +52,7 @@ public function list(): array
 
     public function create(string $extension): WinterExtension
     {
-        throw new ApplicationException('Support for creating extensions needs implementing');
+        throw new ApplicationException('Support for creating modules is not implemented.');
     }
 
     public function install(WinterExtension|ExtensionSource|string $extension): WinterExtension
@@ -88,7 +88,7 @@ public function update(WinterExtension|string|null $extension = null, bool $migr
     {
         $modules = $this->getModuleList($extension);
 
-        $firstUp = UpdateManager::instance()->isSystemSetup();
+        $firstUp = !UpdateManager::instance()->isSystemSetup();
 
         if ($firstUp) {
             $this->repository->createRepository();

diff --git a/modules/system/controllers/updates/traits/ManagesMarketplaceProject.php b/modules/system/controllers/updates/traits/ManagesMarketplaceProject.php
@@ -6,7 +6,7 @@
 use Exception;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Support\Facades\Lang;
-use October\Rain\Exception\ApplicationException;
+use Winter\Storm\Exception\ApplicationException;
 use System\Classes\Core\MarketPlaceApi;
 use System\Models\Parameter;
 use Winter\Storm\Support\Facades\Flash;

diff --git a/modules/system/tests/README.md b/modules/system/tests/README.md
@@ -59,7 +59,8 @@ php artisan plugin:refresh Acme.Blog
 > **Note:** If your plugin uses [configuration files](../plugin/settings#file-configuration), then you will need to run `System\Classes\PluginManager::instance()->registerAll(true);` in the `setUp` method of your tests. Below is an example of a base test case class that should be used if you need to test your plugin working with other plugins instead of in isolation.
 
 ```php
-use System\Classes\Extensions\PluginManager;use System\Tests\Bootstrap\PluginTestCase;
+use System\Classes\Extensions\PluginManager;
+use System\Tests\Bootstrap\PluginTestCase;
 
 class BaseTestCase extends PluginTestCase
 {