feat: add openssl and libsrtp to build dtls and srtp gstreamer plugins in gst-plugins-bad
#1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
changed the title
openssl as dependency for gstreamer bad plugins to include dtlsopenssl and libsrtp to build dtls and srtp gstreamer plugins in gst-plugins-bad
ben-xD
force-pushed
the
dtls
branch
3 times, most recently
from
e25f6ef to
e254cb0
Compare
…e dtls As per https://gitlab.freedesktop.org/Ben-xD/gstreamer/blob/2e198d4e59e107126baafa1b863f75bbdef19c17/subprojects/gst-plugins-bad/ext/dtls/meson.build#L24, dtls is part of gst-plugins-bad, and relies on gstreamer, libcrypto, openssl and winsock2. I haven't confirmed that this works because my build fails when I add `openssl` as a dependency: `gvsbuild build gtk4 pygobject pycairo gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly gst-python webrtc-audio-processing --enable-gi --py-wheel --clean` Just building openssl takes a very long time: `gvsbuild build openssl` (currently building)
ben-xD
force-pushed
the
dtls
branch
2 times, most recently
from
412ac9e to
587818b
Compare
|
I can't seem to get the gstreamer srtp plugin to build. It's missing even with my changes above. I can see |
|
Oh it worked on my other machine, probably caused by not building with
|
danyeaw
reviewed
Jan 7, 2025
gvsbuild/projects/__init__.py
Outdated
| @@ -28,6 +28,7 @@ | |||
| from gvsbuild.projects.gperf import Gperf | |||
| from gvsbuild.projects.graphene import Graphene | |||
| from gvsbuild.projects.gsettings_desktop_schemas import GSettingsDesktopSchemas | |||
| from gvsbuild.projects.libsrtp2 import LibSRTP | |||
There was a problem hiding this comment.
Hi @ben-xD, thanks for the contribution! I'll look in to why Ruff isn't enforcing this automatically, but could you please put libsrt2 in alphabetical order with the other imports? Thanks!
There was a problem hiding this comment.
Hey Dan, sure. I have leveraged my alphabet skills (or lack thereof) in 0b3fe82
danyeaw
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
webrtcbingstreamer element relies on dtls but it's not being built in gvsbuild's GstPluginsBad project. When I tried to usewebrtcbinin my app, I got:I also saw that dtls was missing with gst-inspect-1.0:
As per https://gitlab.freedesktop.org/gstreamer/gstreamer/blob/main/subprojects/gst-plugins-bad/ext/dtls/meson.build#L24, dtls is part of gst-plugins-bad, and relies on gstreamer, libcrypto, openssl and winsock2.
Slow openssl
Adding openssl slows down the build significantly though: