Speeding up 'make check' #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emixa-d
reviewed
Nov 17, 2024
emixa-d
reviewed
Nov 17, 2024
emixa-d
requested changes
Nov 17, 2024
civodul
force-pushed
the
make-check-skips-benchmark-by-default
branch
2 times, most recently
from
45fa498 to
916fab1
Compare
With this change, ‘make check’ runs in 230s on x86_64-linux-gnu (4-core CPU) instead of 880s. * tests/speedup.scm <top level>: Exit with 77 when ‘FIBERS_EXPENSIVE_TESTS’ is unset.
With this change, tests run in 87s instead of 230s on my x86_64 laptop when using ‘guix build -f guix.scm’. * build-aux/guile.am (.scm.go): Set GUILE_AUTO_COMPILE=0. * Makefile.am (TESTS_ENVIRONMENT): Pass ‘--no-auto-compile’. * tests/basic.scm (%long-loop-iterations): New variable. (loop-to-1e4): Rename to… (loop-long-enough): … this. Refer to ‘%long-loop-iterations’. * guix.scm (guile-fibers)[arguments]: Remove. * tests/speedup.scm: Divide by 10 the number of iterations.
civodul
force-pushed
the
make-check-skips-benchmark-by-default
branch
from
916fab1 to
3327e76
Compare
|
I did try to compile tests since that's apparently how they were calibrated but it's not doable: the last attempt failed because So I did the basic thing (same as every other project I've worked with): run tests interpreted and recalibrate the loops so they don't run for ages. |
This was referenced Nov 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures
make checkruns in a timely fashion, particularly in Guix build environments.Why Guix? Because the default
$HOMEin build environments in not writable, meaning that tests were not auto-compiled, and thusloop-to-1e4and similar would take much longer (especially on low-end AArch64 or RISC-V machines where it would typically time out after an hour).