ELYEE-30 Change bean class of produced beans #22
Conversation
|
@manovotn Thank you! The 3.x branch should be enough. I created affiliated issue for this https://issues.redhat.com/browse/ELYEE-30 . Can you please add the ELYEE-30 issue number to the commit? |
|
@darranl Can you please review? |
manovotn
changed the title
Sure, done |
|
@manovotn This code was taken from upstream so I created related PR for soteria with your commit here eclipse-ee4j/soteria#338 |
|
@fjuma The upstream PR got merged: eclipse-ee4j/soteria#338 . I think we can go ahead and merge this PR as well? The files that are being changed by this PR are in the subfolder "original". But since the upstream PR got merged we can merge this to the original as is? |
|
EAP 8.0 Quickstarts bump into this issue again. Can this fix be merged? |
|
@istudens @fjuma This fix was merged and released in soteria 3.0.2 : https://github.com/eclipse-ee4j/soteria/releases/tag/3.0.2-RELEASE , so i think when wildfly upgrades soteria to 3.0.2 this problem should be resolved in quickstarts. This PR can be closed if that is the case AFAIU |
|
@Skyllarr FYI we will likely need this as well whilst we are duplicating the Soteria classes but I think we can consider the upstream merge sufficient review. |
beanClassattribute of beans is used by Weld to determine how and where to define a proxy class. In WFLY, it is used to determine a module whose CL is then used. DefaultbeanClassfor synthetic beans is always their extension class. It can be arbitrary class but using this interface means that Weld will try to create the proxy under Jakarta API module which has no Weld dependencies and that will trigger a WARN message.Related WFLY issue - https://issues.redhat.com/browse/WFLY-17086
Original WFLY PR - wildfly/wildfly#16155
I am not sure if this should also go into
2.xbranch or if it needs a separate issue. Feel free to take it over in any form or shape; I mainly created it as a proposed solution to the original problem :)CC @Skyllarr