Skip to content

Commit

Permalink
Remove WiKit library, wikit tokens and leftovers
Browse files Browse the repository at this point in the history
Bug: T368529
Change-Id: Ia6230bb3c425fef6d04296d1a4082d02b252e2a4
  • Loading branch information
Hasan Akgün committed Dec 9, 2024
1 parent 4778af0 commit 2da493a
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 82 deletions.
4 changes: 1 addition & 3 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,5 @@ updates:
interval: monthly
open-pull-requests-limit: 10
ignore:
- dependency-name: "@wmde/wikit-*"
update-types: ["version-update:semver-major"]
- dependency-name: "vue*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
update-types: ["version-update:semver-major", "version-update:semver-minor"]
6 changes: 0 additions & 6 deletions jest.config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
module.exports = {
preset: 'ts-jest',
transformIgnorePatterns: [
'<rootDir>/node_modules/(?!(@wmde/wikit-vue-components)/)',
],
testEnvironment: '<rootDir>/tests/config/JestCustomEnvironment.js',
testEnvironmentOptions: {
customExportConditions: [ 'node', 'node-addons' ],
Expand All @@ -12,9 +9,6 @@ module.exports = {
moduleNameMapper: {
'^vue$': '@vue/compat',
'^@vue/composition-api$': '@vue/compat',
'^@wmde/wikit-vue-components$':
'@wmde/wikit-vue-components/dist/wikit-vue-components-vue3compat.common.js',
'^wikit-dist(.*)$': '<rootDir>/node_modules/@wmde/wikit-vue-components/dist$1',
'^@/(.*)$': '<rootDir>/src/$1',
'/img/(.*)$': '<rootDir>/tests/config/fileMock.js',
},
Expand Down
45 changes: 0 additions & 45 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
"@wikimedia/codex-design-tokens": "^1.12.0",
"@wikimedia/codex-icons": "^1.0.1",
"@wikimedia/language-data": "^1.1.8",
"@wmde/wikit-tokens": "^2.1.0-alpha.16",
"@wmde/wikit-vue-components": "^2.1.0-alpha.16",
"core-js": "^3.37.1",
"lodash.debounce": "^4.0.8",
"lodash.isequal": "^4.5.0",
Expand Down
1 change: 0 additions & 1 deletion src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ export default defineComponent( {
@import 'ress';
@import '@wikimedia/codex/dist/codex.style-bidi.css';
@import './styles/custom-variables.css';
@import 'wikit-dist/wikit-vue-components-vue3compat.css';
@import './styles/typography';
body {
Expand Down
2 changes: 1 addition & 1 deletion src/components/EntityValueLookup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import EntityLookup from '@/components/EntityLookup.vue';
import SearchOptions from '@/data-access/SearchOptions';
import SearchResult from '@/data-access/SearchResult';
import { MenuItem } from '@wmde/wikit-vue-components/dist/components/MenuItem';
import { MenuItem } from '@/types';
import { PropType } from 'vue';
import { defineComponent } from '@/compat';
import { useStore } from '@/store';
Expand Down
2 changes: 1 addition & 1 deletion src/components/QuantityValueInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import WikitQuantityInput from './WikitQuantityInput.vue';
import { PropType } from 'vue';
import { defineComponent } from '@/compat';
import { MenuItem } from '@wmde/wikit-vue-components/dist/components/MenuItem';
import { MenuItem } from '@/types';
import SearchOptions from '@/data-access/SearchOptions';
import SearchResult from '@/data-access/SearchResult';
import InfoTooltip from '@/components/InfoTooltip.vue';
Expand Down
2 changes: 1 addition & 1 deletion src/components/ReferenceRelationDropDown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import { PropType } from 'vue';
import { defineComponent } from '@/compat';
import ReferenceRelation from '@/data-model/ReferenceRelation';
import { MenuItem } from '@wmde/wikit-vue-components/dist/components/MenuItem';
import { MenuItem } from '@/types';
import { CdxSelect, CdxField } from '@wikimedia/codex';
import InfoTooltip from '@/components/InfoTooltip.vue';
Expand Down
24 changes: 12 additions & 12 deletions src/components/WikitBouncingDots.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,34 +27,34 @@ withDefaults( defineProps<Props>(), {
&::after {
content: '';
display: inline-block;
background-color: $wikit-BouncingDots-background-color;
border-radius: $wikit-BouncingDots-border-radius;
animation: bounce-delay $wikit-BouncingDots-animation-duration infinite ease-in-out both;
animation-delay: $wikit-BouncingDots-animation-delay-default;
background-color: $color-placeholder;
border-radius: $border-radius-circle;
animation: bounce-delay $animation-duration-medium infinite ease-in-out both;
animation-delay: $animation-delay-medium;
}
&::before {
margin-inline-end: $wikit-BouncingDots-margin-right;
animation-delay: $wikit-BouncingDots-animation-delay-before;
margin-inline-end: $spacing-25;
animation-delay: $animation-delay-slow;
}
&::after {
margin-inline-start: $wikit-BouncingDots-margin-left;
animation-delay: $wikit-BouncingDots-animation-delay-after;
margin-inline-start: $spacing-25;
animation-delay: $animation-delay-none;
}
&--small .bounce,
&--small::before,
&--small::after {
inline-size: $wikit-BouncingDots-width-small;
block-size: $wikit-BouncingDots-width-small;
inline-size: $size-75;
block-size: $size-75;
}
&--medium .bounce,
&--medium::before,
&--medium::after {
inline-size: $wikit-BouncingDots-width-medium;
block-size: $wikit-BouncingDots-width-medium;
inline-size: $size-100;
block-size: $size-100;
}
}
Expand Down
1 change: 1 addition & 0 deletions src/components/WikitInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ defineEmits( [ 'update:modelValue' ] );
line-height: $line-height-xx-small;
inline-size: $size-full;
box-sizing: $box-sizing-base;
padding: $spacing-25 $spacing-50;
padding-inline: $spacing-25 $spacing-50;
transition-duration: $transition-duration-medium;
transition-property: $transition-property-base;
Expand Down
1 change: 1 addition & 0 deletions src/components/WikitInputWithExtender.vue
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ function onInput( value: string ): void {
display: flex;
align-items: center;
gap: $spacing-50;
font-weight: $font-weight-bold;
}
&__extension {
Expand Down
2 changes: 1 addition & 1 deletion src/components/WikitPopover.vue
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ watch( () => props.forcePosition, avoidOverflow );

<style lang="scss">
$base: '.wikit-Popover';
$pointer-edge-length: math.hypot($wikit-Popover-pointer-width / 2, $wikit-Popover-pointer-height);
$pointer-edge-length: math.hypot($size-100 / 2, $size-50);
#{$base} {
display: inline-block;
Expand Down
9 changes: 0 additions & 9 deletions vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ export default {
find: '@vue/composition-api',
replacement: '@vue/compat',
},
{
find: 'wikit-dist',
replacement: path.resolve( __dirname, './node_modules/@wmde/wikit-vue-components/dist' ),
},
{
find: '@wmde/wikit-vue-components',
replacement: '@wmde/wikit-vue-components/dist/wikit-vue-components-vue3compat.common.js',
},
],
},
server: {
Expand All @@ -63,7 +55,6 @@ export default {
// @use 'sass:math' is for WikitPopover component
additionalData: `
@use 'sass:math';
@import "@wmde/wikit-tokens/dist/variables";
@import '@wikimedia/codex-design-tokens/theme-wikimedia-ui';
`,
},
Expand Down

0 comments on commit 2da493a

Please sign in to comment.