Add TinyMCE 6 module #762
Merged
Add TinyMCE 6 module #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also removed the ImageUploadHelper et al and JazzySpellChecker (is now done directly via browser API) and the InPlaceEditComponent. |
martin-g
reviewed
Feb 14, 2024
tinymce6-parent/tinymce6/src/main/java/wicket/contrib/tinymce6/TinyMceInitializer.java
Outdated
Show resolved
Hide resolved
martin-g
approved these changes
Feb 21, 2024
|
Thank you, @renoth ! |
|
@renoth shall we drop |
+1 |
|
I would update tinymce4 to the latest version of TinyMCE 4 since it works just fine. This module does have some features removed compared to TinyMCE4. |
|
Looking at the vulnerabilities again, i think it is time to drop TinyMCE 4 as well |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are serious security issues with TinyMCE 4 and 5 https://security.snyk.io/package/npm/tinymce
Furthermore TinyMCE 4 is not updated in wicketstuff tinymce 4 and still on version 4.3.4,
see also https://security.snyk.io/package/npm/tinymce/4.3.5
The migration to TinyMCE 6 should be straightforward but there are some plugins which have become usable only with subscription.
This implementation only supports the free part of TinyMCE 6 retrieved from here https://www.tiny.cloud/get-tiny/self-hosted/
If you like the changes, please do a codereview (and maybe merge later).
Thank you for your time.