feat(config): standardize boolean value with YAML tags. Fixes numapro…

…j#1742 (numaproj#1749) Signed-off-by: charans29 <[email protected]>
whynowy · Jun 5, 2024 · b26008e · b26008e
1 parent 71bc030
commit b26008e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/docs/development/debugging.md b/docs/development/debugging.md
@@ -21,7 +21,7 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: out
       sink:
         log: {}
@@ -46,7 +46,7 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
 ```
 
 ## Profiling

diff --git a/examples/7-reduce-sliding-window.yaml b/examples/7-reduce-sliding-window.yaml
@@ -10,14 +10,14 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
       source:
         http: {}
     - name: map
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
       scale:
         min: 1
         max: 1
@@ -44,7 +44,7 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: sink
       scale:
         min: 1

diff --git a/test/e2e/testdata/watermark.yaml b/test/e2e/testdata/watermark.yaml
@@ -15,7 +15,7 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: cat1
       partitions: 2
       udf:
@@ -24,15 +24,15 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: cat2
       udf:
         builtin:
           name: cat # A builtin UDF which simply cats the message
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: cat3
       partitions: 3
       udf:
@@ -41,7 +41,7 @@ spec:
       containerTemplate:
         env:
           - name: NUMAFLOW_DEBUG
-            value: "true" # DO NOT forget the double quotes!!!
+            value: !!str "true"
     - name: output1
       sink:
         # A simple log printing sink

diff --git a/test/manifests/kustomization.yaml b/test/manifests/kustomization.yaml
@@ -19,7 +19,7 @@ patches:
         path: /spec/template/spec/containers/0/env/-
         value:
           name: NUMAFLOW_DEBUG
-          value: "true"
+          value: !!str "true"
     target:
       kind: Deployment
       name: numaflow-controller