add s3 url support in MVTiles Layer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-willis
force-pushed
the
s3-tile-layer-support
branch
from
9da5a4a to
62cacb9
Compare
james-willis
commented
Mar 7, 2024
| @@ -31,7 +32,7 @@ setup-env: | |||
| test `command -v python3` || echo Please install python3 | |||
| test `command -v yarn` || echo Please install yarn | |||
| test `command -v python3` && test `command -v yarn` | |||
| python3 -m venv env | |||
| python3 -m venv $(WORKON_HOME) | |||
There was a problem hiding this comment.
This change was made to allow local installations to put the venv outside of the project directory. This is in order to avoid the following error when running make prepare-jupyter:
ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/Volumes/CaseSensitive/deck.gl/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
at file:///Volumes/CaseSensitive/deck.gl/bindings/pydeck/env/lib/python3.8/site-packages/jupyterlab/node-version-check.js:6:13
at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)
at async loadESM (node:internal/process/esm_loader:34:7)
at async handleMainPromise (node:internal/modules/run_main:106:12)
I do not understand why this occurs only on local and not in the github actions test run.
james-willis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just creating this pull request to see how the tests run