Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WebSocketStream Interface #48

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

The WebSocketStream Interface #48

Changes from 10 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
579e413
[WIP] The WebSocketStream Interface
ricea Nov 11, 2021
3c4803b
Fix grammatical errors
ricea Jan 23, 2024
8e5f06b
Note that backpressure is obeyed for writable
ricea Jan 23, 2024
5cb355b
Remove mention of passing close code or reason to abort() or cancel()
ricea Jan 23, 2024
1f9a2d6
Revert "Remove mention of passing close code or reason to abort() or …
ricea Jan 28, 2024
96baeed
Mention that it has to be a WebSocketError
ricea Jan 28, 2024
69bae4f
Add IDL for WebSocketError
ricea Jan 28, 2024
fa5ff83
Add algorithm steps for WebSocketStream and WebSocketError
ricea Jan 28, 2024
adf4bbe
Changes from reviews
ricea Jan 30, 2024
f488ee4
Add missing AbortSignal algorithm steps.
ricea Jan 30, 2024
b1a58f4
Use Bikeshed magic to get a URL record
ricea Jan 31, 2024
8cc184c
Add missing colon
ricea Jan 31, 2024
7812163
Remove "the user agent must run..."
ricea Jan 31, 2024
47ab0da
Fix capitalisation of "close"
ricea Jan 31, 2024
2b9ee80
Server can't send a bad reason, and wording improvement (by @domenic)
ricea Jan 31, 2024
12ff404
Editorial changes from @domenic. Also change `closeCode` to [EnforceR…
ricea Jan 31, 2024
a2fc7c2
Change `|this|` to `[=this=]` everywhere
ricea Jan 31, 2024
3a285c7
Fix initialization of dictionaries and WebSocketErrors
ricea Jan 31, 2024
397dd00
Demote "Feedback from the protocol" and "The CloseEvent interface"
ricea Jan 31, 2024
9e8d8f7
Indent "Garbage Collection" and fix the WebSocketStream interface ena…
ricea Feb 1, 2024
673ace9
Use "queue a global task"
ricea Feb 6, 2024
30f5f8b
Explicitly say what realm write algorithm's promise is created in
ricea Feb 6, 2024
7d85772
Add more <hr>s
ricea Feb 6, 2024
1d7d868
Place The WebSocket Protocol in <cite> tags
ricea Feb 6, 2024
7b81f79
Fix many small nits from domenic@'s review
ricea Feb 6, 2024
6da74e7
Add a missing comma
ricea Feb 21, 2024
16a75fe
Fix description of "was ever connected"
ricea Feb 21, 2024
2bd7ad5
Fix grammar in developer notes
ricea Feb 21, 2024
b2e001c
Apply cleanups by @domenic.
ricea Feb 21, 2024
1e2eae9
Fixes requested by @domenic
ricea Feb 21, 2024
24f24f8
Fix Bikeshed compile error
ricea Feb 21, 2024
a6d426f
Set defaults for WebSocketError's closeCode and reason
ricea Feb 21, 2024
d5570f3
Add default arguments
ricea Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading