Editorial: small cleanup after #1326 #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 8, 2025
…=arai,smaug This splits ReadableByteStreamControllerCommitPullIntoDescriptor from ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue so that close/chunk steps will run only after processing all descriptors, thus preventing user JS from potentially modifying anything during the process. Corresponding to whatwg/streams#1326 with some cleanup in whatwg/streams#1336. Differential Revision: https://phabricator.services.mozilla.com/D232663
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 8, 2025
…=arai,smaug This splits ReadableByteStreamControllerCommitPullIntoDescriptor from ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue so that close/chunk steps will run only after processing all descriptors, thus preventing user JS from potentially modifying anything during the process. Corresponding to whatwg/streams#1326 with some cleanup in whatwg/streams#1336. Differential Revision: https://phabricator.services.mozilla.com/D232663
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 8, 2025
…=arai,smaug This splits ReadableByteStreamControllerCommitPullIntoDescriptor from ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue so that close/chunk steps will run only after processing all descriptors, thus preventing user JS from potentially modifying anything during the process. Corresponding to whatwg/streams#1326 with some cleanup in whatwg/streams#1336. Differential Revision: https://phabricator.services.mozilla.com/D232663
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jan 10, 2025
…=arai,smaug This splits ReadableByteStreamControllerCommitPullIntoDescriptor from ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue so that close/chunk steps will run only after processing all descriptors, thus preventing user JS from potentially modifying anything during the process. Corresponding to whatwg/streams#1326 with some cleanup in whatwg/streams#1336. Differential Revision: https://phabricator.services.mozilla.com/D232663
MattiasBuelens
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing some repeats and using list/size instead of a separate counter.
Preview | Diff