Define an algorithm to create a Set from a List #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/set-from-list
branch
from
29f528e to
875a5f5
Compare
OrKoN
changed the title
domenic
reviewed
Dec 19, 2024
infra.bs
Outdated
| @@ -1694,6 +1694,16 @@ unordered one, since interoperability requires that any developer-exposed enumer | |||
| contents be consistent between browsers. In those cases where order is not important, we still use | |||
| ordered sets; implementations can optimize based on the fact that the order is not observable. | |||
|
|
|||
| <div algorithm> | |||
| <p>To <dfn export for=set>create a set</dfn>, given a [=/list=] |input|: | |||
There was a problem hiding this comment.
Hmm, I'd prefer naming this either <dfn export>create a set from a list</dfn>, or <dfn export for="set">create</dfn>. The latter makes sense if we think there's no other reasonable input for creating a set, whereas the former is more specific.
There was a problem hiding this comment.
Went for <dfn export for="set">create</dfn>. I think creating from other data structures is less common. Nevertheless, the create steps could accept a generic iterator instead of a list but since that is not currently specified it probably makes sense to just use the list.
annevk
reviewed
Dec 19, 2024
OrKoN
force-pushed
the
orkon/set-from-list
branch
from
644f5a4 to
7182a7f
Compare
annevk
approved these changes
Dec 19, 2024
|
Thanks Alex! |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the WebDriver BiDi spec, there is a need to convert lists created from JSON messages into sets for internal algorithms. This PR adds a helper to define how the operation of creating a set from a list should be performed. The operation seems to be common and relatively straight-forward so it might make sense that the Infra standard defines it.
Preview | Diff